ScoutAPM

[JPrevost]

Developer

Ticket(s)

https://mitlibraries.atlassian.net/browse/TCO-87

Accessibility

• ANDI or Wave has been run in accordance to our guide and
  all issues introduced by these changes have been resolved or opened
  as new issues (link to those issues in the Pull Request details above)
• There are no accessibility implications to this change

Documentation

• Project documentation has been updated, and yard output previewed
• No documentation changes are needed

ENV

• All new ENV is documented in README.
• All new ENV has been added to Heroku Pipeline, Staging and Prod.
• ENV has not changed.

Stakeholders

• Stakeholder approval has been confirmed
• Stakeholder approval is not needed

Dependencies and migrations

YES dependencies are updated

NO migrations are included

Reviewer

Code

• I have confirmed that the code works as intended.
• Any CodeClimate issues have been fixed or confirmed as
  added technical debt.

Documentation

• The commit message is clear and follows our guidelines
  (not just this pull request message).
• The documentation has been updated or is unnecessary.
• New dependencies are appropriate or there were no changes.

Testing

• There are appropriate tests covering any new functionality.
• No additional test coverage is required.

[matt-bernhardt]

This seems pretty straightforward. Looking at the ENV in the PR build, I see an example of one of those other variables that you mention in the readme, and I see the pointer to where I can find those documented - which feels fine to me.

My only non-blocking question is about what "staging" means to Scout - does it's worldview automatically align with Heroku's tier names?

[matt-bernhardt]

Non-blocking, but I'm curious about what the definition of "staging" is in Scout terms. I see above that we're blocking test and dev tiers from sending anything to Scout, but we're also not blocking staging - so I'm not sure what Scout's worldview is for the various Heroku tiers.

[JPrevost]

This is a generated config file. We don't name any Environments staging so it is never used. All of our Heroku Environments are production as far as Rails is concerned. We'll very likely just explicitly disable (via SCOUT_MONITOR: false in PR builds. I'm not sure we'll know exactly what we'll need until we are a bit further into this... at which point I hope we remember to go back and update the docs with our actual implementation...