Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade heroku stack to 24 #85

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Upgrade heroku stack to 24 #85

merged 1 commit into from
Aug 14, 2024

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Aug 13, 2024

Bumps heroku stack from 22 to 24. I've tested the build process and GraphQL playground and haven't noticed any issues.

Developer

Ticket(s)

https://mitlibraries.atlassian.net/browse/TCO-47

Accessibility

  • ANDI or Wave has been run in accordance to our guide and
    all issues introduced by these changes have been resolved or opened
    as new issues (link to those issues in the Pull Request details above)
  • There are no accessibility implications to this change

Documentation

  • Project documentation has been updated, and yard output previewed
  • No documentation changes are needed

ENV

  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.

Stakeholders

  • Stakeholder approval has been confirmed
  • Stakeholder approval is not needed

Dependencies and migrations

YES dependencies are updated (sort of -- Heroku stack)

NO migrations are included

Reviewer

Code

  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.

Documentation

  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.

Testing

  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@mitlib mitlib temporarily deployed to tacos-api-pipeline-pr-85 August 13, 2024 20:48 Inactive
@jazairi jazairi changed the title Upgrade heroku stack to 24 DO NOT MERGE Upgrade heroku stack to 24 Aug 13, 2024
@jazairi jazairi marked this pull request as ready for review August 13, 2024 20:49
@jazairi jazairi marked this pull request as draft August 13, 2024 20:51
@jazairi jazairi changed the title DO NOT MERGE Upgrade heroku stack to 24 Upgrade heroku stack to 24 Aug 14, 2024
@jazairi jazairi force-pushed the tco-47-upgrade-heroku-stack branch from 2bd3d4f to e9d045f Compare August 14, 2024 13:27
@jazairi jazairi temporarily deployed to tacos-api-pipeline-pr-85 August 14, 2024 13:27 Inactive
Relevant tickets:

* [TCO-47](https://mitlibraries.atlassian.net/browse/TCO-47)

Side effects of this change:

The app name in `app.json` has been corrected.
@jazairi jazairi force-pushed the tco-47-upgrade-heroku-stack branch from e9d045f to bfa5841 Compare August 14, 2024 13:28
@jazairi jazairi temporarily deployed to tacos-api-pipeline-pr-85 August 14, 2024 13:28 Inactive
@jazairi jazairi marked this pull request as ready for review August 14, 2024 13:29
@jazairi jazairi merged commit 806ecc3 into main Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants