Validation workflow prototype A: code-based #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes here are still workshopping how we want to handle the data model - there isn't a single change that's being proposed yet.
This is an affordance to set up the demonstration for Wednesday
Update validation workflow doc Update workflow explanation This adds the Ruby code block to categorize all terms
This should support a class to record the output of our various detectors, which should allow processing this output to place terms into a category. Test coverage is woeful.
This is not as efficient as it could be. Because the Detector model only stores a boolean, rather than a pointer to which SR record was detected, we have to re-run the full_term_match method and look up the relevant category that way. This is a prototype, so hopefully this is okay for now.
matt-bernhardt
force-pushed
the
tco-69-code
branch
from
3c6f358 to
3c9efa6
Compare
|
This prototype is no longer needed. The choice of a path forward for the data model has been made, and this prototype was not selected. I'm going to leave the branch in place just in case, but that's it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a roughly working prototype of one method for implementing a categorization and validation workflow, leaning more heavily on a code-based approach rather than one rooted in data modeling and database records.
This is really rough, and likely to be squashed and re-written as things progress. Please don't base any branches off of these commits.
Developer
Ticket(s)
https://mitlibraries.atlassian.net/browse/TCO-###
Accessibility
all issues introduced by these changes have been resolved or opened
as new issues (link to those issues in the Pull Request details above)
Documentation
ENV
Stakeholders
Dependencies and migrations
YES | NO dependencies are updated
YES | NO migrations are included
Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing