Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraphQL for Detector::SuggestedResource #97

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented Aug 26, 2024

Why these changes are being introduced:

We have a SuggestedResource detector that is not yet modeled in our GraphQL.

Relevant ticket(s):

How this addresses that need:

This adds a SuggestedResourcesType as a field on DetectorsType.

Side effects of this change:

None.

Developer

Ticket(s)

https://mitlibraries.atlassian.net/browse/TCO-###

Accessibility

  • ANDI or Wave has been run in accordance to our guide and
    all issues introduced by these changes have been resolved or opened
    as new issues (link to those issues in the Pull Request details above)
  • There are no accessibility implications to this change

Documentation

  • Project documentation has been updated, and yard output previewed (GraphQL descriptions added)
  • No documentation changes are needed

ENV

  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.

Stakeholders

  • Stakeholder approval has been confirmed
  • Stakeholder approval is not needed

Dependencies and migrations

NO dependencies are updated

NO migrations are included

Reviewer

Code

  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.

Documentation

  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.

Testing

  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

Why these changes are being introduced:

We have a `SuggestedResource` detector that is not yet modeled in
our GraphQL.

Relevant ticket(s):

* [TCO-24](https://mitlibraries.atlassian.net/browse/TCO-24)

How this addresses that need:

This adds a `SuggestedResourcesType` as a field on `DetectorsType`.

Side effects of this change:

None.
@mitlib mitlib temporarily deployed to tacos-api-pipeline-pr-97 August 26, 2024 20:50 Inactive
@jazairi
Copy link
Contributor Author

jazairi commented Aug 26, 2024

Noting as this goes into review that I've not yet confirmed this works in the GraphQL playground. (I don't have suggested resources loaded locally.) I will confirm with a staging deploy before merging.

@matt-bernhardt matt-bernhardt self-assigned this Aug 27, 2024
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and I've confirmed that the playground now returns suggestedResources inside the detectors block when those are loaded (although please double check on staging, as you've said, in case my local is idiosyncratic somehow).

:shipit:

@jazairi
Copy link
Contributor Author

jazairi commented Aug 27, 2024

I just confirmed detections in staging, so I think we're good to merge. Thanks for the review!

@jazairi jazairi merged commit cfd7a95 into main Aug 27, 2024
3 checks passed
@jazairi jazairi deleted the tco-24-suggested-resource-graphql branch August 27, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants