Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance 10-2024 #358

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Maintenance 10-2024 #358

merged 2 commits into from
Oct 25, 2024

Conversation

ehanson8
Copy link
Contributor

Purpose and background context

Updates app according to our maintenance week documentation.

How can a reviewer manually see the effects of these changes?

Run make test and make lint to confirm they still pass

Includes new or updated dependencies?

YES

Changes expectations for external applications?

NO

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

  • The commit message is clear and follows our guidelines (not just this PR message)
  • There are appropriate tests covering any new functionality
  • The provided documentation is sufficient for understanding any new functionality introduced
  • Any manual tests have been performed or provided examples have been verified
  • New dependencies are appropriate or there were no changes

ghukill
ghukill approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@ghukill ghukill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty minimal, looks good!

@ehanson8 ehanson8 merged commit b6e8893 into main Oct 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonavellecuerdo jonavellecuerdo jonavellecuerdo approved these changes

@ghukill ghukill ghukill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehanson8 @ghukill @jonavellecuerdo