Adds support for AND, OR, custom keyword matching #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why are these changes being introduced: * TIMDEX currently ORs all keyword searches together which leads to a lot of search results, many of which are not relevant (to the extreme of sometimes having no records returned that have all the terms which is sometimes the expectation) Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/GDT-281 How does this address that need: * Leverages OpenSearch `minimum_should_match` [feature](https://opensearch.org/docs/latest/query-dsl/minimum-should-match/#valid-values) along with a GraphQL feature to choose a preconfigured value or supply your own Document any side effects to this change: * once we get feedback from stakeholders, it is likely we'll want to adjust the options available, document them more thoroughly in the API docs, and provide them with meaningful names, as well as probably remove some of the options
JPrevost
commented
Apr 19, 2024
JPrevost
commented
Apr 19, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
jazairi
approved these changes
Apr 19, 2024
Document any side effects to this change: - some options will be available but not documented. If we choose to keep them beyond our initial experiments, we should name them appropriately and document them. More than likely they'll be removed so not publicly advertising them makes sense unless we want open feedback (which we're not looking for yet)
JPrevost
force-pushed
the
gdt-281-more-than-or
branch
from
80dfb0c to
26fc86b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: while you can use the GraphQL playground to review these changes, there is also an experimental branch of TIMDEX-UI deployed and configured to use this branch that may also be helpful to more easily see the effects of these proposed changes.
Why are these changes being introduced:
Relevant ticket(s):
How does this address that need:
minimum_should_matchfeature along with a GraphQL feature to choose a preconfigured value or supply your ownDocument any side effects to this change:
Developer
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO