Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Optimize flamechart][4/4] Split FlamechartView into row views
Allow the view system to render only affected flamechart rows. This greatly improves flamechart hover performance, which has a high impact on our app's performance as the flamechart is the slowest view to render. Also adds a new `ColorView` view that fills the flamechart area with a solid background color to fix these issues: 1. Black empty areas appearing below flamecharts without much stack depth 2. Lines appearing between flamechart rows. My hypothesis is that these are appearing due to subpixel rendering, even though the flamechart rows' `visibleArea`s are all integers. Related to #50. * `yarn flow`: no errors in changed code * `yarn lint` * `yarn start`: 60 FPS hovers on our Facebook.com profile * `yarn test`
- Loading branch information
5fe70a3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs: