Use integers when calling canvas draw methods #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't this make things slightly inaccurate or smaller? |
|
Didn't really think about that, but I think subpixel rendering would appear to be more inaccurate to users? |
|
You're rounding all values and their computed values, I think you should definitely take a look if this is causing some things to look misaligned. You would have to zoom in a lot to find the misalignments though. |
|
You're right, some things do appear to be misaligned. This isn't worth the perf improvements then, if there are any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #50.
Not sure if this actually does anything useful as our performance metrics aren't precise enough, but using integers instead of floating points is recommended by quite a few online sources including https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Optimizing_canvas#Avoid_floating-point_coordinates_and_use_integers_instead
Pushing this PR separately from more major work as I think I'm out of tiny optimizations. The next few PRs are likely going to be large ones.
Poked app, everything still works.