-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optimization flag to fix irreproducibility on KNL/Intel #37
Add optimization flag to fix irreproducibility on KNL/Intel #37
Conversation
reproducibility issues on some machines also replaced deprecated -FR flag with -free for free-form source
@philipwjones Thanks! I am testing my supported download cases for MPAS V6 this week, I can easily test this PR at the same time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be more accurate to change "optimization" to "alignment" or something similar in the title? Otherwise, this looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, looks good. I did a test merge and ocean core compile with intel and gnu to be sure.
added -align array64byte flag to optimized Intel builds to fix reproducibility issues on some machines (KNL) also replaced deprecated -FR flag with -free to denote free-form source B4B Tested on Cori, Edison at NERSC Replaces previous PR in MPAS-Dev/MPAS MPAS-Dev/MPAS#1520 though see discussion therein. Fixes previously reported bug in MPAS-Dev/MPAS MPAS-Dev/MPAS#1519
New Mesh: SOwISC12to60E2r4 Long name: SOwISC12to60kmL60E3SMv2r4 This version of the Southern Ocean Regionally Refined Mesh (SORRM) includes: * 12 km resolution around Antarctica, about 1000 km farther north than in revision 3 of the mesh * 45 km resolution at southern mid-latitudes * 30 km resolution at the equator and the north Atlantic * 60 km resolution in the north Pacific * 35 km resolution in the Arctic It matches the EC30to60 mesh except in the Southern Ocean and north Atlantic. The merge includes some reorganization of the SOwISC test cases within COMPASS: * the "resolution" has been renamed from `SO10to60wISC` to `SOwISC12to60` * a new test case `files_for_e3sm` has been added to create the initial condition, graph files, analysis region masks and mapping files, etc. The script that produces files for E3SM has been modified to use the short name of the mesh in output file names, rather than the long name. Initial condition, spin-up and files for E3SM are on Anvil at: ``` lcrc/group/e3sm/ac.xylar/mpas/spinup_expand_hr_SOwISC12to60E2r4/ocean/global_ocean/SOwISC12to60/ ```
added -align array64byte flag to optimized Intel builds to fix reproducibility issues on some machines (KNL)
also replaced deprecated -FR flag with -free to denote free-form source
B4B
Tested on Cori, Edison at NERSC
Replaces previous PR in MPAS-Dev/MPAS
MPAS-Dev/MPAS#1520
though see discussion therein.
Fixes previously reported bug in MPAS-Dev/MPAS
MPAS-Dev/MPAS#1519