another CMatrixDynamic ctor made explicit

MRPT · Nov 30, 2023 · 6b7284e · 6b7284e
1 parent 9ac18fb
commit 6b7284e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/doc/source/doxygen-docs/changelog.md b/doc/source/doxygen-docs/changelog.md
@@ -11,6 +11,7 @@
 - BUG FIXES:
   - Fix missing Threads::Threads downstream due to missing `find_dependency(Threads)` in MRPT cmake config files.
   - Fix broken import of PLY files in SceneViewer3D (empty scene even if correctly imported).
+  - mrpt::math::CMatrixDynamic constructor from (row,col) was not marked explicit, leading to potential problems.
 
 
 # Version 2.11.3: Released Nov 21st, 2023

diff --git a/libs/math/include/mrpt/math/CMatrixDynamic.h b/libs/math/include/mrpt/math/CMatrixDynamic.h
@@ -150,7 +150,10 @@ class CMatrixDynamic : public MatrixBase<T, CMatrixDynamic<T>>
 	/** Constructors */
 	CMatrixDynamic(const CMatrixDynamic& m) { (*this) = m; }
 
-	CMatrixDynamic(size_t row = 0, size_t col = 0) { realloc(row, col); }
+	explicit CMatrixDynamic(size_t row = 0, size_t col = 0)
+	{
+		realloc(row, col);
+	}
 
 	/** Copy (casting from if needed) from another matrix  */
 	template <typename U>