Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission General Information ULAM #529

Merged
merged 36 commits into from
Feb 13, 2025
Merged

Conversation

aleckvincent
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Feb 3, 2025

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 57.56% (🎯 40%) 2633 / 4574
🟢 Statements 56.31% (🎯 40%) 2741 / 4867
🟢 Functions 41.92% (🎯 40%) 646 / 1541
🟢 Branches 48.71% (🎯 40%) 1061 / 2178
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
frontend/src/v2/features/auth/hooks/use-auth.tsx 9.09% 0% 0% 9.09% 17-55
frontend/src/v2/features/common/components/layout/mission-list-page-title.tsx 33.33% 0% 0% 33.33% 11-19
frontend/src/v2/features/common/components/layout/mission-page-header-wrapper.tsx 50% 0% 0% 50% 31, 40-101
frontend/src/v2/features/common/components/ui/mission-crew-list.tsx 37.5% 0% 0% 40.9% 24-31, 34-44, 47-57, 61-70, 72-75, 78-83, 86-97, 100
frontend/src/v2/features/common/hooks/use-abstract-formik-form.tsx 73.07% 41.66% 83.33% 85.71% 16, 36-38, 48
frontend/src/v2/features/common/hooks/use-abstract-formik-sub-form.tsx 87.5% 50% 66.66% 100% 19
frontend/src/v2/features/common/services/use-agents.tsx 16.66% 100% 0% 25% 7-14
frontend/src/v2/features/common/services/use-mission-crews-by-mission.tsx 0% 100% 0% 0% 6-14
frontend/src/v2/features/common/services/use-user.tsx 16.66% 100% 0% 25% 6-13
frontend/src/v2/features/common/types/control-unit-types.ts 0% 0% 0% 0% 39
frontend/src/v2/features/common/types/mission-types.ts 100% 100% 100% 100%
frontend/src/v2/features/mission-action/components/ui/mission-action-formik-date-range-picker.tsx 73.68% 60% 100% 75% 26, 34-38
frontend/src/v2/features/mission-action/hooks/use-mission-action-generic-date-observation.tsx 0% 0% 0% 0% 13-50
frontend/src/v2/features/ulam/components/element/mission-create-dialog.tsx 100% 100% 100% 100%
frontend/src/v2/features/ulam/components/element/mission-create-new-ulam.tsx 57.14% 50% 42.85% 72.72% 29-30, 54
frontend/src/v2/features/ulam/components/element/mission-general-information-control-unit-resource.tsx 3.57% 0% 0% 4.54% 19-90
frontend/src/v2/features/ulam/components/element/mission-general-information-crew-ulam.tsx 4% 0% 0% 5.26% 29-97
frontend/src/v2/features/ulam/components/element/mission-general-information-extended-form-ulam.tsx 11.11% 0% 0% 11.11% 23-68
frontend/src/v2/features/ulam/components/element/mission-general-information-form-ulam.tsx 16.66% 0% 0% 16.66% 20-44
frontend/src/v2/features/ulam/components/element/mission-general-information-initial-form-ulam.tsx 100% 66.66% 100% 100%
frontend/src/v2/features/ulam/components/element/mission-general-information-service-ulam.tsx 4.16% 0% 0% 5% 17-91
frontend/src/v2/features/ulam/components/element/mission-general-information-ulam.tsx 7.69% 0% 0% 10% 15-27
frontend/src/v2/features/ulam/components/element/mission-list/mission-list-ulam.tsx 100% 100% 100% 100%
frontend/src/v2/features/ulam/components/ui/mission-crew-form.tsx 20% 0% 0% 26.31% 19-23, 25-30, 33, 39-50, 64-120
frontend/src/v2/features/ulam/components/ui/mission-crew-list-item-ulam.tsx 25% 100% 0% 25% 18-27
frontend/src/v2/features/ulam/components/ui/mission-general-information-service-form.tsx 0% 0% 0% 0% 13-57
frontend/src/v2/features/ulam/components/ui/mission-icon-ulam.tsx 100% 50% 100% 100%
frontend/src/v2/features/ulam/components/ui/mission-list-ulam-action.tsx 0% 100% 0% 0% 4-8
frontend/src/v2/features/ulam/hooks/use-submit-mission-general-information.tsx 6.25% 0% 0% 6.66% 18-78
frontend/src/v2/features/ulam/hooks/use-ulam-mission-general-informations-extended-form.tsx 0% 100% 0% 0% 9-21
frontend/src/v2/features/ulam/hooks/use-ulam-mission-general-informations-initial-form.tsx 76.92% 100% 60% 76.92% 29-34, 51
frontend/src/v2/features/ulam/services/use-administrations.tsx 16.66% 100% 0% 25% 7-15
frontend/src/v2/features/ulam/services/use-control-unit-resources.tsx 16.66% 100% 0% 25% 7-15
frontend/src/v2/features/ulam/services/use-create-mission.tsx 11.11% 100% 0% 12.5% 8-21
frontend/src/v2/features/ulam/services/use-update-generalInfo.tsx 11.11% 100% 0% 12.5% 8-21
frontend/src/v2/features/ulam/services/use-update-mission.tsx 0% 100% 0% 0% 8-22
frontend/src/v2/pages/mission-list-pam-page.tsx 5.71% 0% 0% 6.06% 31-125
frontend/src/v2/pages/mission-list-ulam-page.tsx 9.52% 0% 0% 9.52% 29-95
frontend/src/v2/pages/mission-ulam-page.tsx 7.14% 0% 0% 9.09% 23-69
Generated in workflow #1758 for commit 85f7a5d by the Vitest Coverage Report Action

Copy link

github-actions bot commented Feb 3, 2025

Overall Project 50.05% -0.36%
Files changed 6.83%

File Coverage
GetAgentsCrewByMissionId.kt 100% 🍏
MissionCrewEntity.kt 74.07% 🍏
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CrewRestController.kt 0% -82.69%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
JPAMissionCrewRepository.kt 0% -12.7%
DeleteMissionCrew.kt 0% -32.26%

Copy link

github-actions bot commented Feb 4, 2025

Overall Project 50.05% -0.36%
Files changed 6.83%

File Coverage
GetAgentsCrewByMissionId.kt 100% 🍏
MissionCrewEntity.kt 74.07% 🍏
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CrewRestController.kt 0% -82.69%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
JPAMissionCrewRepository.kt 0% -12.7%
DeleteMissionCrew.kt 0% -32.26%

@aleckvincent aleckvincent marked this pull request as ready for review February 6, 2025 11:18
@aleckvincent aleckvincent force-pushed the feature/mission-general-info-ulam branch from e8c1a34 to cb92c13 Compare February 6, 2025 14:23
Copy link

github-actions bot commented Feb 6, 2025

Overall Project 49.93% -1.47%
Files changed 18.53%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
MissionGeneralInfo2.kt 81.21% -9.17%
APIEnvControlUnitRepository.kt 81.15% 🍏
MissionGeneralInfoModel.kt 78.37% -13.83%
MissionGeneralInfoEntity.kt 75.34% -13.9%
MissionCrewEntity.kt 74.07% 🍏
MissionGeneralInfo.kt 73.89% -3.89%
MissionRestController.kt 66.54% -19.23%
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -78.57%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -95.89%
CrewRestController.kt 0% -87.39%
ControlUnitResourceRestController.kt 0% -76.92%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
CreateOrUpdateEnvMission.kt 0% -54.5%
JPAMissionCrewRepository.kt 0% -22.58%
GetControlUnitResources.kt 0% -76.92%
DeleteMissionCrew.kt 0% -32.26%

 - UserRestController
 - UserRestController Test
 - UserInfos class
 - Get User infos and display
@xtiannyeto xtiannyeto force-pushed the feature/mission-general-info-ulam branch from e37712e to 12620df Compare February 9, 2025 19:24
Copy link

github-actions bot commented Feb 9, 2025

Overall Project 49.95% -1.47%
Files changed 19.65%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
MissionGeneralInfo2.kt 82.35% -8.61%
APIEnvControlUnitRepository.kt 81.15% 🍏
MissionGeneralInfoModel.kt 78.37% -13.83%
MissionGeneralInfoEntity.kt 75.34% -13.9%
MissionCrewEntity.kt 74.07% 🍏
MissionGeneralInfo.kt 73.89% -3.89%
MissionRestController.kt 66.54% -19.23%
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -78.57%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -95.89%
CrewRestController.kt 0% -87.39%
ControlUnitResourceRestController.kt 0% -76.92%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
CreateOrUpdateEnvMission.kt 0% -54.97%
JPAMissionCrewRepository.kt 0% -22.58%
GetControlUnitResources.kt 0% -76.92%
DeleteMissionCrew.kt 0% -32.26%

Copy link

Overall Project 49.95% -1.47%
Files changed 19.65%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
MissionGeneralInfo2.kt 82.35% -8.61%
APIEnvControlUnitRepository.kt 81.15% 🍏
MissionGeneralInfoModel.kt 78.37% -13.83%
MissionGeneralInfoEntity.kt 75.34% -13.9%
MissionCrewEntity.kt 74.07% 🍏
MissionGeneralInfo.kt 73.89% -3.89%
MissionRestController.kt 66.54% -19.23%
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -78.57%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -95.89%
CrewRestController.kt 0% -87.39%
ControlUnitResourceRestController.kt 0% -76.92%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
CreateOrUpdateEnvMission.kt 0% -54.97%
JPAMissionCrewRepository.kt 0% -22.58%
GetControlUnitResources.kt 0% -76.92%
DeleteMissionCrew.kt 0% -32.26%

Copy link

Overall Project 49.58% -2.12%
Files changed 14.42%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
MissionGeneralInfo2.kt 82.35% -8.61%
APIEnvControlUnitRepository.kt 81.15% 🍏
MissionGeneralInfoModel.kt 78.37% -13.83%
MissionGeneralInfoEntity.kt 75.34% -13.9%
MissionCrewEntity.kt 74.07% 🍏
MissionGeneralInfo.kt 73.89% -3.89%
MissionRestController.kt 66.54% -19.23%
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -78.57%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -93.62%
FullAdministration.kt 0% -84.62%
CrewRestController.kt 0% -87.39%
ControlUnitResourceRestController.kt 0% -76.92%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
AdministrationController.kt 0% -87.76%
APIEnvAdministrationRepository.kt 0% -96.88%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
AdministrationEntity.kt 0% -91.43%
CreateOrUpdateEnvMission.kt 0% -54.97%
JPAMissionCrewRepository.kt 0% -22.58%
GetControlUnitResources.kt 0% -76.92%
FullAdministrationDataOutput.kt 0% -78.57%
ControlUnitDataOutput.kt 0% -95.89%
GetAdministrations.kt 0% -93.18%
GetAdministrationById.kt 0% -90.32%
DeleteMissionCrew.kt 0% -32.26%

Copy link

Overall Project 49.56% -2.41%
Files changed 17.64%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
MissionGeneralInfo2.kt 81.85% -9.66%
APIEnvControlUnitRepository.kt 81.15% 🍏
MissionGeneralInfo.kt 77.67% -9.67%
MissionGeneralInfoEntity.kt 75.31% -14.64%
MissionGeneralInfoModel.kt 74.27% -19.89%
MissionCrewEntity.kt 74.07% 🍏
MissionRestController.kt 66.54% -19.23%
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -78.57%
InterMinisterialServiceModel.kt 0% -96.7%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -93.62%
FullAdministration.kt 0% -84.62%
CrewRestController.kt 0% -87.39%
ControlUnitResourceRestController.kt 0% -76.92%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
AdministrationController.kt 0% -87.76%
APIEnvAdministrationRepository.kt 0% -96.88%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
AdministrationEntity.kt 0% -91.43%
InterMinisterialService.kt 0% -93.18%
CreateOrUpdateEnvMission.kt 0% -55.21%
JPAMissionCrewRepository.kt 0% -22.58%
InterMinisterialServiceEntity.kt 0%
GetControlUnitResources.kt 0% -76.92%
FullAdministrationDataOutput.kt 0% -78.57%
ControlUnitDataOutput.kt 0% -95.89%
GetAdministrations.kt 0% -93.18%
GetAdministrationById.kt 0% -90.32%
DeleteMissionCrew.kt 0% -32.26%

Copy link

Overall Project 49.45% -2.62%
Files changed 17.41%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
APIEnvControlUnitRepository.kt 81.15% 🍏
MissionGeneralInfo.kt 77.67% -9.67%
MissionGeneralInfoModel.kt 74.27% -19.89%
MissionCrewEntity.kt 74.07% 🍏
MissionGeneralInfo2.kt 73.06% -19.37%
MissionGeneralInfoEntity.kt 68.97% -21.84%
MissionRestController.kt 66.54% -19.23%
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -78.57%
InterMinisterialServiceModel.kt 0% -96.91%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -93.62%
FullAdministration.kt 0% -84.62%
CrewRestController.kt 0% -87.39%
ControlUnitResourceRestController.kt 0% -76.92%
MissionGeneralInfoRestController.kt 0% -64.71%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
AdministrationController.kt 0% -87.76%
APIEnvAdministrationRepository.kt 0% -96.88%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
JPAMissionGeneralInfoRepository.kt 0% -12.5%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
AdministrationEntity.kt 0% -91.43%
InterMinisterialService.kt 0% -96.15%
CreateOrUpdateEnvMission.kt 0% -55.21%
JPAMissionCrewRepository.kt 0% -22.58%
InterMinisterialServiceEntity.kt 0%
GetControlUnitResources.kt 0% -76.92%
FullAdministrationDataOutput.kt 0% -78.57%
ControlUnitDataOutput.kt 0% -95.89%
GetAdministrations.kt 0% -93.18%
GetAdministrationById.kt 0% -90.32%
DeleteMissionCrew.kt 0% -32.26%

Copy link

Overall Project 49.45% -2.62%
Files changed 17.41%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
APIEnvControlUnitRepository.kt 81.15% 🍏
MissionGeneralInfo.kt 77.67% -9.67%
MissionGeneralInfoModel.kt 74.27% -19.89%
MissionCrewEntity.kt 74.07% 🍏
MissionGeneralInfo2.kt 73.06% -19.37%
MissionGeneralInfoEntity.kt 68.97% -21.84%
MissionRestController.kt 66.54% -19.23%
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -78.57%
InterMinisterialServiceModel.kt 0% -96.91%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -93.62%
FullAdministration.kt 0% -84.62%
CrewRestController.kt 0% -87.39%
ControlUnitResourceRestController.kt 0% -76.92%
MissionGeneralInfoRestController.kt 0% -64.71%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
AdministrationController.kt 0% -87.76%
APIEnvAdministrationRepository.kt 0% -96.88%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
JPAMissionGeneralInfoRepository.kt 0% -12.5%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
AdministrationEntity.kt 0% -91.43%
InterMinisterialService.kt 0% -96.15%
CreateOrUpdateEnvMission.kt 0% -55.21%
JPAMissionCrewRepository.kt 0% -22.58%
InterMinisterialServiceEntity.kt 0%
GetControlUnitResources.kt 0% -76.92%
FullAdministrationDataOutput.kt 0% -78.57%
ControlUnitDataOutput.kt 0% -95.89%
GetAdministrations.kt 0% -93.18%
GetAdministrationById.kt 0% -90.32%
DeleteMissionCrew.kt 0% -32.26%

import fr.gouv.dgampa.rapportnav.infrastructure.api.bff.model.v2.MissionEnv
import fr.gouv.dgampa.rapportnav.infrastructure.api.bff.model.v2.generalInfo.MissionGeneralInfo2
import org.slf4j.LoggerFactory

@UseCase
class CreateEnvMission(
class CreateOrUpdateEnvMission(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi CreateOrUPdate?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On crée chez Env et on Update (missionTypes cf: mon msg dans mattermost)

}

@PostMapping("/multiple")
fun addMultipleMissionCrews(@RequestBody crews: List<MissionCrew>): List<MissionCrew>? {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to this


@PostMapping("")
fun addOrUpdateMissionCrew(@RequestBody crew: MissionCrew): MissionCrew? {
return try {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to this either

}
}

@GetMapping("/mission/{missionId}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the global route of this controller should be
/api/v2/missions/{missionId}/crews

parce que un crew est toujours assigné a une mission

throw java.lang.IllegalArgumentException("missionId doesn't match with request param")
}
try {
val mission = createOrUpdateEnvMission.execute(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why createOrUpdate?? we create a mission and we update general information of a mission! right?


private val logger = LoggerFactory.getLogger(IEnvAdministrationRepository::class.java)

private val host = "https://monitorenv.din.developpement-durable.gouv.fr"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variables now :D

private val logger = LoggerFactory.getLogger(APIEnvControlUnitResourceRepository::class.java)
private val client = clientFactory.create();

private val host = "https://monitorenv.din.developpement-durable.gouv.fr" // TODO: to be replaced by env var
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variables now :D


useEffect(() => {
if (fieldFormik.field.value?.length === 0) return
console.log(fieldFormik.field.value)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all console.log

@aleckvincent aleckvincent force-pushed the feature/mission-general-info-ulam branch from d9a3540 to 9ceb5bc Compare February 12, 2025 16:02
Copy link

Overall Project 49.29% -2.61%
Files changed 17.38%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
MissionRestController.kt 83.17% -0.48% 🍏
APIEnvControlUnitRepository.kt 81.15% 🍏
MissionGeneralInfoModel.kt 78.34% -14.65%
MissionGeneralInfo.kt 77.67% -9.67%
MissionCrewEntity.kt 74.07% 🍏
MissionGeneralInfo2.kt 73.06% -19.37%
MissionGeneralInfoEntity.kt 68.97% -21.84%
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -87.18%
AddOrUpdateInterMinisterialService.kt 0% -85.37%
InterMinisterialServiceModel.kt 0% -97.58%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -93.62%
FullAdministration.kt 0% -84.62%
CrewRestController.kt 0% 🍏
ControlUnitResourceRestController.kt 0% -76.92%
MissionGeneralInfoRestController.kt 0% -64.71%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
AdministrationController.kt 0% -87.76%
APIEnvAdministrationRepository.kt 0% -96.88%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
JPAInterMinisterialServiceRepository.kt 0% -83.02%
JPAMissionGeneralInfoRepository.kt 0% -12.5%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
AdministrationEntity.kt 0% -91.43%
InterMinisterialService.kt 0% -96.15%
CreateOrUpdateEnvMission.kt 0% -55.21%
JPAMissionCrewRepository.kt 0% -22.58%
InterMinisterialServiceEntity.kt 0%
GetControlUnitResources.kt 0% -76.92%
FullAdministrationDataOutput.kt 0% -78.57%
ControlUnitDataOutput.kt 0% -95.89%
GetAdministrations.kt 0% -93.18%
GetAdministrationById.kt 0% -90.32%
DeleteMissionCrew.kt 0% -32.26%

@aleckvincent aleckvincent force-pushed the feature/mission-general-info-ulam branch from 9ceb5bc to 99d1116 Compare February 13, 2025 08:43
Copy link

Overall Project 49.29% -2.61%
Files changed 17.38%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
MissionRestController.kt 83.17% -0.48% 🍏
APIEnvControlUnitRepository.kt 81.15% 🍏
MissionGeneralInfoModel.kt 78.34% -14.65%
MissionGeneralInfo.kt 77.67% -9.67%
MissionCrewEntity.kt 74.07% 🍏
MissionGeneralInfo2.kt 73.06% -19.37%
MissionGeneralInfoEntity.kt 68.97% -21.84%
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -87.18%
AddOrUpdateInterMinisterialService.kt 0% -85.37%
InterMinisterialServiceModel.kt 0% -97.58%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -93.62%
FullAdministration.kt 0% -84.62%
CrewRestController.kt 0% 🍏
ControlUnitResourceRestController.kt 0% -76.92%
MissionGeneralInfoRestController.kt 0% -64.71%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
AdministrationController.kt 0% -87.76%
APIEnvAdministrationRepository.kt 0% -96.88%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
JPAInterMinisterialServiceRepository.kt 0% -83.02%
JPAMissionGeneralInfoRepository.kt 0% -12.5%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
AdministrationEntity.kt 0% -91.43%
InterMinisterialService.kt 0% -96.15%
CreateOrUpdateEnvMission.kt 0% -55.21%
JPAMissionCrewRepository.kt 0% -22.58%
InterMinisterialServiceEntity.kt 0%
GetControlUnitResources.kt 0% -76.92%
FullAdministrationDataOutput.kt 0% -78.57%
ControlUnitDataOutput.kt 0% -95.89%
GetAdministrations.kt 0% -93.18%
GetAdministrationById.kt 0% -90.32%
DeleteMissionCrew.kt 0% -32.26%

Copy link

Overall Project 49.29% -2.61%
Files changed 17.38%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
MissionRestController.kt 83.17% -0.48% 🍏
APIEnvControlUnitRepository.kt 81.15% 🍏
MissionGeneralInfoModel.kt 78.34% -14.65%
MissionGeneralInfo.kt 77.67% -9.67%
MissionCrewEntity.kt 74.07% 🍏
MissionGeneralInfo2.kt 73.06% -19.37%
MissionGeneralInfoEntity.kt 68.97% -21.84%
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -87.18%
AddOrUpdateInterMinisterialService.kt 0% -85.37%
InterMinisterialServiceModel.kt 0% -97.58%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -93.62%
FullAdministration.kt 0% -84.62%
CrewRestController.kt 0% 🍏
ControlUnitResourceRestController.kt 0% -76.92%
MissionGeneralInfoRestController.kt 0% -64.71%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
AdministrationController.kt 0% -87.76%
APIEnvAdministrationRepository.kt 0% -96.88%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
JPAInterMinisterialServiceRepository.kt 0% -83.02%
JPAMissionGeneralInfoRepository.kt 0% -12.5%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
AdministrationEntity.kt 0% -91.43%
InterMinisterialService.kt 0% -96.15%
CreateOrUpdateEnvMission.kt 0% -55.21%
JPAMissionCrewRepository.kt 0% -22.58%
InterMinisterialServiceEntity.kt 0%
GetControlUnitResources.kt 0% -76.92%
FullAdministrationDataOutput.kt 0% -78.57%
ControlUnitDataOutput.kt 0% -95.89%
GetAdministrations.kt 0% -93.18%
GetAdministrationById.kt 0% -90.32%
DeleteMissionCrew.kt 0% -32.26%

Copy link

Overall Project 49.36% -2.53%
Files changed 19.8%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
MissionRestController.kt 86.94% -0.37% 🍏
APIEnvControlUnitRepository.kt 81.15% 🍏
MissionGeneralInfoModel.kt 78.34% -14.65%
MissionGeneralInfo.kt 77.67% -9.67%
MissionCrewEntity.kt 74.07% 🍏
MissionGeneralInfo2.kt 73.06% -19.37%
MissionGeneralInfoEntity.kt 68.97% -21.84%
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -84.89%
AddOrUpdateInterMinisterialService.kt 0% -85.37%
InterMinisterialServiceModel.kt 0% -97.58%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -93.62%
FullAdministration.kt 0% -84.62%
CrewRestController.kt 0% 🍏
ControlUnitResourceRestController.kt 0% -76.92%
MissionGeneralInfoRestController.kt 0% -64.71%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
AdministrationController.kt 0% -87.76%
APIEnvAdministrationRepository.kt 0% -96.88%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
JPAInterMinisterialServiceRepository.kt 0% -83.02%
JPAMissionGeneralInfoRepository.kt 0% -12.5%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
AdministrationEntity.kt 0% -91.43%
InterMinisterialService.kt 0% -96.15%
CreateOrUpdateEnvMission.kt 0% -23.48%
JPAMissionCrewRepository.kt 0% -22.58%
InterMinisterialServiceEntity.kt 0%
GetControlUnitResources.kt 0% -76.92%
FullAdministrationDataOutput.kt 0% -78.57%
ControlUnitDataOutput.kt 0% -95.89%
GetAdministrations.kt 0% -93.18%
GetAdministrationById.kt 0% -90.32%
DeleteMissionCrew.kt 0% -32.26%

Copy link

Overall Project 49.36% -2.53%
Files changed 19.8%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
MissionRestController.kt 86.94% -0.37% 🍏
APIEnvControlUnitRepository.kt 81.15% 🍏
MissionGeneralInfoModel.kt 78.34% -14.65%
MissionGeneralInfo.kt 77.67% -9.67%
MissionCrewEntity.kt 74.07% 🍏
MissionGeneralInfo2.kt 73.06% -19.37%
MissionGeneralInfoEntity.kt 68.97% -21.84%
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -84.89%
AddOrUpdateInterMinisterialService.kt 0% -85.37%
InterMinisterialServiceModel.kt 0% -97.58%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -93.62%
FullAdministration.kt 0% -84.62%
CrewRestController.kt 0% 🍏
ControlUnitResourceRestController.kt 0% -76.92%
MissionGeneralInfoRestController.kt 0% -64.71%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
AdministrationController.kt 0% -87.76%
APIEnvAdministrationRepository.kt 0% -96.88%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
JPAInterMinisterialServiceRepository.kt 0% -83.02%
JPAMissionGeneralInfoRepository.kt 0% -12.5%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
AdministrationEntity.kt 0% -91.43%
InterMinisterialService.kt 0% -96.15%
CreateOrUpdateEnvMission.kt 0% -23.48%
JPAMissionCrewRepository.kt 0% -22.58%
InterMinisterialServiceEntity.kt 0%
GetControlUnitResources.kt 0% -76.92%
FullAdministrationDataOutput.kt 0% -78.57%
ControlUnitDataOutput.kt 0% -95.89%
GetAdministrations.kt 0% -93.18%
GetAdministrationById.kt 0% -90.32%
DeleteMissionCrew.kt 0% -32.26%

Copy link

Overall Project 49.36% -2.53%
Files changed 19.8%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
MissionRestController.kt 86.94% -0.37% 🍏
APIEnvControlUnitRepository.kt 81.15% 🍏
MissionGeneralInfoModel.kt 78.34% -14.65%
MissionGeneralInfo.kt 77.67% -9.67%
MissionCrewEntity.kt 74.07% 🍏
MissionGeneralInfo2.kt 73.06% -19.37%
MissionGeneralInfoEntity.kt 68.97% -21.84%
MissionCrewModel.kt 59.63% -11.8%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -84.89%
AddOrUpdateInterMinisterialService.kt 0% -85.37%
InterMinisterialServiceModel.kt 0% -97.58%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -93.62%
FullAdministration.kt 0% -84.62%
CrewRestController.kt 0% 🍏
ControlUnitResourceRestController.kt 0% -76.92%
MissionGeneralInfoRestController.kt 0% -64.71%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
AdministrationController.kt 0% -87.76%
APIEnvAdministrationRepository.kt 0% -96.88%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
JPAInterMinisterialServiceRepository.kt 0% -83.02%
JPAMissionGeneralInfoRepository.kt 0% -12.5%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
AdministrationEntity.kt 0% -91.43%
InterMinisterialService.kt 0% -96.15%
CreateOrUpdateEnvMission.kt 0% -23.48%
JPAMissionCrewRepository.kt 0% -22.58%
InterMinisterialServiceEntity.kt 0%
GetControlUnitResources.kt 0% -76.92%
FullAdministrationDataOutput.kt 0% -78.57%
ControlUnitDataOutput.kt 0% -95.89%
GetAdministrations.kt 0% -93.18%
GetAdministrationById.kt 0% -90.32%
DeleteMissionCrew.kt 0% -32.26%

@aleckvincent aleckvincent force-pushed the feature/mission-general-info-ulam branch from 0cd9fdd to 6926fbe Compare February 13, 2025 12:25
Copy link

Overall Project 49.67% -2.58%
Files changed 22.23%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
MissionRestController.kt 86.94% -0.37% 🍏
APIEnvControlUnitRepository.kt 81.15% 🍏
UserRestController.kt 78.38% -21.62%
MissionGeneralInfoModel.kt 78.34% -14.65%
MissionGeneralInfo.kt 77.67% -9.67%
MissionCrewEntity.kt 74.07% 🍏
MissionGeneralInfo2.kt 73.06% -19.37%
MissionGeneralInfoEntity.kt 68.97% -21.84%
MissionCrewModel.kt 59.63% -11.8%
UserInfos.kt 59.15% -40.85%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -84.89%
AddOrUpdateInterMinisterialService.kt 0% -85.37%
InterMinisterialServiceModel.kt 0% -97.58%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -93.62%
FullAdministration.kt 0% -84.62%
CrewRestController.kt 0% 🍏
ControlUnitResourceRestController.kt 0% -76.92%
MissionGeneralInfoRestController.kt 0% -64.71%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
AdministrationController.kt 0% -87.76%
APIEnvAdministrationRepository.kt 0% -96.88%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
JPAInterMinisterialServiceRepository.kt 0% -83.02%
JPAMissionGeneralInfoRepository.kt 0% -12.5%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
AdministrationEntity.kt 0% -91.43%
InterMinisterialService.kt 0% -96.15%
CreateOrUpdateEnvMission.kt 0% -23.48%
JPAMissionCrewRepository.kt 0% -22.58%
InterMinisterialServiceEntity.kt 0%
GetControlUnitResources.kt 0% -76.92%
FullAdministrationDataOutput.kt 0% -78.57%
ControlUnitDataOutput.kt 0% -95.89%
GetAdministrations.kt 0% -93.18%
GetAdministrationById.kt 0% -90.32%
DeleteMissionCrew.kt 0% -32.26%

Copy link

Overall Project 49.67% -2.58%
Files changed 22.23%

File Coverage
MissionSourceEnum.kt 100% 🍏
GetAgentsCrewByMissionId.kt 100% 🍏
APIEnvMissionRepositoryV2.kt 88.11% 🍏
MissionRestController.kt 86.94% -0.37% 🍏
APIEnvControlUnitRepository.kt 81.15% 🍏
UserRestController.kt 78.38% -21.62%
MissionGeneralInfoModel.kt 78.34% -14.65%
MissionGeneralInfo.kt 77.67% -9.67%
MissionCrewEntity.kt 74.07% 🍏
MissionGeneralInfo2.kt 73.06% -19.37%
MissionGeneralInfoEntity.kt 68.97% -21.84%
MissionCrewModel.kt 59.63% -11.8%
UserInfos.kt 59.15% -40.85%
ExportMissionPatrolSingle.kt 4.26% -0.64%
ExportMissionRapportPatrouille.kt 4.2% -0.64%
CreateOrUpdateGeneralInfo.kt 0% -84.89%
AddOrUpdateInterMinisterialService.kt 0% -85.37%
InterMinisterialServiceModel.kt 0% -97.58%
ControlUnitResourceEnv.kt 0% -87.88%
StationData.kt 0% -90%
ControlUnit.kt 0% -93.62%
FullAdministration.kt 0% -84.62%
CrewRestController.kt 0% 🍏
ControlUnitResourceRestController.kt 0% -76.92%
MissionGeneralInfoRestController.kt 0% -64.71%
AgentRoleController.kt 0% -86.36%
AgentRestController.kt 0% -87.67%
AdministrationController.kt 0% -87.76%
APIEnvAdministrationRepository.kt 0% -96.88%
APIEnvControlUnitResourceRepository.kt 0% -94.12%
JPAInterMinisterialServiceRepository.kt 0% -83.02%
JPAMissionGeneralInfoRepository.kt 0% -12.5%
MissionCrew.kt 0% -47.62%
Agent.kt 0% -25.93%
ControlUnitResourceEntity.kt 0%
ControlUnitResourceType.kt 0%
ControlResourceEntity.kt 0% -27.59%
AdministrationEntity.kt 0% -91.43%
InterMinisterialService.kt 0% -96.15%
CreateOrUpdateEnvMission.kt 0% -23.48%
JPAMissionCrewRepository.kt 0% -22.58%
InterMinisterialServiceEntity.kt 0%
GetControlUnitResources.kt 0% -76.92%
FullAdministrationDataOutput.kt 0% -78.57%
ControlUnitDataOutput.kt 0% -95.89%
GetAdministrations.kt 0% -93.18%
GetAdministrationById.kt 0% -90.32%
DeleteMissionCrew.kt 0% -32.26%

@aleckvincent aleckvincent merged commit d894624 into main Feb 13, 2025
9 checks passed
@aleckvincent aleckvincent deleted the feature/mission-general-info-ulam branch February 13, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants