-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mission General Information ULAM #529
Conversation
|
|
e8c1a34
to
cb92c13
Compare
|
- UserRestController - UserRestController Test - UserInfos class
- Get User infos and display
e37712e
to
12620df
Compare
|
|
|
|
|
|
import fr.gouv.dgampa.rapportnav.infrastructure.api.bff.model.v2.MissionEnv | ||
import fr.gouv.dgampa.rapportnav.infrastructure.api.bff.model.v2.generalInfo.MissionGeneralInfo2 | ||
import org.slf4j.LoggerFactory | ||
|
||
@UseCase | ||
class CreateEnvMission( | ||
class CreateOrUpdateEnvMission( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pourquoi CreateOrUPdate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On crée chez Env et on Update (missionTypes cf: mon msg dans mattermost)
} | ||
|
||
@PostMapping("/multiple") | ||
fun addMultipleMissionCrews(@RequestBody crews: List<MissionCrew>): List<MissionCrew>? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to this
|
||
@PostMapping("") | ||
fun addOrUpdateMissionCrew(@RequestBody crew: MissionCrew): MissionCrew? { | ||
return try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to this either
.../gouv/dgampa/rapportnav/domain/use_cases/mission/v2/administrations/GetAdministrationById.kt
Show resolved
Hide resolved
} | ||
} | ||
|
||
@GetMapping("/mission/{missionId}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the global route of this controller should be
/api/v2/missions/{missionId}/crews
parce que un crew est toujours assigné a une mission
throw java.lang.IllegalArgumentException("missionId doesn't match with request param") | ||
} | ||
try { | ||
val mission = createOrUpdateEnvMission.execute( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why createOrUpdate?? we create a mission and we update general information of a mission! right?
|
||
private val logger = LoggerFactory.getLogger(IEnvAdministrationRepository::class.java) | ||
|
||
private val host = "https://monitorenv.din.developpement-durable.gouv.fr" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variables now :D
private val logger = LoggerFactory.getLogger(APIEnvControlUnitResourceRepository::class.java) | ||
private val client = clientFactory.create(); | ||
|
||
private val host = "https://monitorenv.din.developpement-durable.gouv.fr" // TODO: to be replaced by env var |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variables now :D
|
||
useEffect(() => { | ||
if (fieldFormik.field.value?.length === 0) return | ||
console.log(fieldFormik.field.value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove all console.log
d9a3540
to
9ceb5bc
Compare
|
9ceb5bc
to
99d1116
Compare
|
|
|
|
|
- Refaction Create Mission modal - use formik array on crew - Remove backend calls over crew - Plan service - Plan resource
- Extended form - global form
- Component resources and services
0cd9fdd
to
6926fbe
Compare
|
|
No description provided.