[TRA-15158] Possibilité de réviser la quantité refusée d'un BSD + correctifs #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GaelFerrand
commented
Feb 18, 2025
| @@ -41,19 +41,21 @@ export function BsddRequestRevisionCancelationInput({ bsdd, onChange }: Props) { | |||
| CANCELLABLE_BSDD_STATUSES.includes(bsdd.status) && !isAppendix1; | |||
|
|
|||
| return ( | |||
| <> | |||
| <div className="fr-mb-4v"> | |||
There was a problem hiding this comment.
J'ai ajouté une petite marge au niveau du swtich d'annulation parce que c'était pas beau
GaelFerrand
commented
Feb 18, 2025
| @@ -33,7 +34,7 @@ const LabelContent = ({ | |||
| defaultValue?: string | number | React.ReactNode; | |||
| suffix?: string; | |||
| }) => | |||
| !!value ? ( | |||
| isDefined(value) ? ( | |||
There was a problem hiding this comment.
Attention avec !!, ça marche pas avec zéro. Donc ça n'affichait pas un champ révisé qui passe de zéro à une autre valeur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contexte
Implémentation front de la révision de la
quantityRefused, avec en bonus un petit fix pour ne pas afficher la révision sur les quantités tant que le déchet n'a pas été reçu.Points de vigilance pour les intégrateurs
Il est possible d'utiliser la révision pour ajouter une
quantityRefusedà un bordereau qui n'en avait pas. Vous pouvez donc utiliser la révision pour corriger des bordereaux legacy.Démo
Screencast.from.2025-02-18.14-49-54.webm
Ticket Favro
Permettre de réviser la quantité refusée lors d'un refus partiel