Collections #1810
Draft
Collections #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve url handling and visualization
ffont
reviewed
Jan 16, 2025
fscollections/models.py
Outdated
| class Collection(models.Model): | ||
|
|
||
| author = models.ForeignKey(User, on_delete=models.CASCADE) | ||
| name = models.CharField(max_length=128, default="BookmarkCollection") #add restrictions |
ffont
reviewed
Feb 3, 2025
| @@ -927,6 +928,8 @@ | |||
| # ------------------------------------------------------------------------------- | |||
| # Extra Freesound settings | |||
|
|
|||
There was a problem hiding this comment.
Maybe rename this to ENABLE COLLECTIONS?
ffont
reviewed
Feb 3, 2025
|
|
||
| user = models.ForeignKey(User, on_delete=models.CASCADE) | ||
| name = models.CharField(max_length=255) #max_length as in Packs (128 for Bookmarks) | ||
| created = models.DateTimeField(db_index=True, auto_now_add=True) |
ffont
reviewed
Feb 3, 2025
| collection = models.ForeignKey(Collection, related_name='collectionsound', on_delete=models.CASCADE) | ||
| created = models.DateTimeField(db_index=True, auto_now_add=True) | ||
|
|
||
| STATUS_CHOICES = ( |
ffont
reviewed
Feb 3, 2025
| def delete_collection(request, collection_id): | ||
| collection = get_object_or_404(Collection, id=collection_id) | ||
|
|
||
| if request.user==collection.user: |
There was a problem hiding this comment.
Consider else case, return 404 or reload edit page but with a message saying that user is not allowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
#1029
Description
App creation and first implementations of basic functionalitites for collections.