Remove unnecessary user field from geotag #1820
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alastair
force-pushed
the
geotag-remove-user
branch
from
0405599 to
42b1b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
Fixes #1036
Description
The
geotag.userfield just replicated the same value that was insound.user, no need to keep it.Looking at this further, we should probably denormalise the table properly. This means that instead of having
sound.geotag, we havegeotag.sound. Django's ORM should take care of the queries exactly the same here, but it means that we can get rid of thegeotagcolumn, which is mostly filled with nulls. I'll take a look at adding this change on to this PR.Deployment steps:
Includes migration