Add sitemap for sounds #1821
Open
Add sitemap for sounds #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
Fixes #1374
Description
Add a new sitemap.xml to include a list of all of our pages and when they were updated.
This needs to be tested with more sounds in the database - theoretically django should automatically split it into 50k items per sitemap (the max allowed). But this is a relatively expensive db query to get the information. It's possible that we can reduce the number of fields that we retrieve.
There is also a way of caching this data: https://docs.djangoproject.com/en/5.1/ref/contrib/sitemaps/#creating-a-sitemap-index which we could take a look at.
Also consider which other items to add to the sitemap - packs? forums?
The URL also needs to be added to robots.txt