Merge pull request #410 from MUnique/fix-infinity-arrow-adding

Fix infinity arrow adding after quest completion

src/GameLogic/Player.cs

@@ -1786,9 +1786,26 @@ private void RaisePlayerLeftMap(GameMap map)
         this.PlayerLeftMap?.Invoke(this, (this, map));
     }
 
+    /// <summary>
+    /// Adds the missing stat attributes, e.g. after the character class has been changed outside of the game.
+    /// </summary>
+    private void AddMissingStatAttributes()
+    {
+        if (this.SelectedCharacter is not { CharacterClass: { } characterClass } character)
+        {
+            return;
+        }
+
+        var missingStats = characterClass.StatAttributes.Where(a => this.SelectedCharacter.Attributes.All(c => c.Definition != a.Attribute));
+
+        var attributes = missingStats.Select(a => this.PersistenceContext.CreateNew<StatAttribute>(a.Attribute, a.BaseValue)).ToList();
+        attributes.ForEach(character.Attributes.Add);
+    }
+
     private async ValueTask OnPlayerEnteredWorldAsync()
     {
         this.Attributes = new ItemAwareAttributeSystem(this.Account!, this.SelectedCharacter!);
+        this.AddMissingStatAttributes();
         this.Inventory = new InventoryStorage(this, this.GameContext);
         this.ShopStorage = new ShopStorage(this);
         this.TemporaryStorage = new Storage(InventoryConstants.TemporaryStorageSize, new TemporaryItemStorage());
@@ -2123,4 +2140,4 @@ public GMMagicEffectDefinition()
             this.PowerUpDefinitions = new List<PowerUpDefinition>(0);
         }
     }
-}
+}

src/Persistence/Initialization/GameConfigurationInitializerBase.cs

@@ -39,6 +39,7 @@ public override void Initialize()
     {
         this.GameConfiguration.ExperienceRate = 1.0f;
         this.GameConfiguration.MaximumLevel = 400;
+        this.GameConfiguration.MaximumMasterLevel = 400;
         this.GameConfiguration.InfoRange = 12;
         this.GameConfiguration.AreaSkillHitsPlayer = false;
         this.GameConfiguration.MaximumInventoryMoney = int.MaxValue;

src/Persistence/Initialization/Updates/InfinityArrowSkillOnQuestCompletionPlugIn.cs

@@ -62,5 +62,6 @@ protected override async ValueTask ApplyAsync(IContext context, GameConfiguratio
         skillReward.Value = 1;
         skillReward.SkillReward = gameConfiguration.Skills.First(s => s.Number == (short)SkillNumber.InfinityArrow);
         skillReward.RewardType = QuestRewardType.Skill;
+        quest.Rewards.Add(skillReward);
     }
 }

src/Persistence/Initialization/Updates/UpdateVersion.cs

@@ -83,5 +83,5 @@ public enum UpdateVersion
     /// <summary>
     /// The version of the <see cref="InfinityArrowSkillOnQuestCompletionPlugIn"/>.
     /// </summary>
-    InfinityArrowSkillOnQuestCompletion = 14,
+    InfinityArrowSkillOnQuestCompletion = 15,
 }

src/Persistence/Initialization/VersionSeasonSix/Quests.cs

@@ -249,6 +249,7 @@ private void GainHeroStatus(CharacterClassNumber characterClass)
             skillReward.Value = 1;
             skillReward.SkillReward = this.GameConfiguration.Skills.First(s => s.Number == (short)SkillNumber.InfinityArrow);
             skillReward.RewardType = QuestRewardType.Skill;
+            heroStatus.Rewards.Add(skillReward);
         }
 
         heroStatus.Rewards.Add(pointReward);