Correctly handle partial JSON at the end of a chunk #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Streaming a response occasionally encounters the error
"The given data was not valid JSON."
Related Issues: #97 #103
Why
The end of a chunk can have an incomplete JSON.
The rest of the JSON will come through at the beginning of the next chunk.
Affected Areas
StreamingSession.swift
More Info
This change stores the last JSON from the chunk and appends it to the beginning of the next chunk.
A likely partial JSON is stored when:
ResultType
decoding failsAPIErrorResponse
decoding failsHaving an incomplete JSON at the end of a chunk is seemingly random - likely based on OpenAI server load etc.
A request that surfaces this issue more often than not is:
"Write 1 to 40 using bullet points"
Kudos to @jcmourey for suggesting the fix in #97