Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove legacy completions endpoint #160

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

kalafus
Copy link
Contributor

@kalafus kalafus commented Feb 5, 2024

What

remove legacy completions endpoint (uses obsolete models and truncates responses)

Why

legacy .completions(query: CompletionsQuery) endpoint technically still works, but it frequently truncates responses. the .chats(query: ChatQuery) endpoint is available and not janky.

Affected Areas

.completions(query: CompletionsQuery)

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
1.0% Duplication on New Code

See analysis details on SonarCloud

@kalafus
Copy link
Contributor Author

kalafus commented Feb 16, 2024

Pull includes a deprecation message for the /v1/completions endpoint, which, some kind of deprecation message is probably technically the correct path at this time..

Copy link
Collaborator

@nezhyborets nezhyborets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

@nezhyborets nezhyborets merged commit add6cfb into MacPaw:main Jan 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants