-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Антон Белов home_work_2 #9
base: master
Are you sure you want to change the base?
Conversation
@@ -73,37 +73,44 @@ fun Shop.example(): Int? = customers.map { it.orders }.flatten().find { it.id == | |||
//TODO | |||
|
|||
//Преобразовать список клиентов в сет | |||
fun Shop.getSetOfCustomers(): Set<Customer> = setOf() | |||
fun Shop.getSetOfCustomers(): Set<Customer> = this.customers.toSet() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this в котлине не нужен
|
||
// Вернуть список клиентов из представленного города | ||
fun Shop.getCustomersFrom(city: City): List<Customer> = listOf() | ||
fun Shop.getCustomersFrom(city: City): List<Customer> = | ||
this.customers.filter { it.city == city }.toList() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.toList() лишний
|
||
// Вернуть словарь в котором названия городов являются ключами, а значениями - сет клиентов, проживающих в этом городе | ||
fun Shop.groupCustomersByCity(): Map<String, Set<Customer>> = mapOf() | ||
fun Shop.groupCustomersByCity(): Map<String, Set<Customer>> = | ||
this.customers.map { it.city.title to mutableSetOf(it) }.toMap() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ошибка. У тебя всегда перезаписывается значение в словаре. То есть всегда только один клиент из города будет, даже если их на самом деле несколько
|
||
// Вернуть сет клиентов, у которых не доставленных заказов больше чем заказанных | ||
fun Shop.getCustomersWithMoreUndeliveredOrdersThanDelivered(): Set<Customer> = setOf() | ||
fun Shop.getCustomersWithMoreUndeliveredOrdersThanDelivered(): Set<Customer> = | ||
this.customers.filter { it.orders.filter { !it.isDelivered }.size > it.orders.filter { it.isDelivered }.size } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.filter { !it.isDelivered }.size можно заменить на .count{ !it.isDelivered }
fun Shop.getNumberOfTimesProductWasOrdered(product: Product): Int = | ||
this.customers.map { it.orders.flatMap { it.products }.filter { it == product } }.size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
та же история что и до этого, можно заменить на count с условием
No description provided.