Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MOI.ScalarNonLinearFunction #280

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

frapac
Copy link
Collaborator

@frapac frapac commented Nov 16, 2023

Address #279

@frapac frapac requested a review from sshin23 November 16, 2023 20:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 71.56550% with 89 lines in your changes missing coverage. Please review.

Project coverage is 72.42%. Comparing base (f0effa2) to head (42a6369).
Report is 57 commits behind head on master.

Files with missing lines Patch % Lines
src/Interfaces/MOI_interface.jl 54.60% 69 Missing ⚠️
src/Interfaces/utils.jl 87.57% 20 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
- Coverage   75.36%   72.42%   -2.94%     
==========================================
  Files          40       41       +1     
  Lines        4120     4762     +642     
==========================================
+ Hits         3105     3449     +344     
- Misses       1015     1313     +298     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sshin23 sshin23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @frapac!

@frapac frapac merged commit 9a4ce89 into master Nov 22, 2023
5 of 6 checks passed
@frapac frapac deleted the fp/scalarnonlinearfunction branch November 22, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants