-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve kkt creation on GPUs #299
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #299 +/- ##
==========================================
- Coverage 68.75% 68.75% -0.01%
==========================================
Files 42 41 -1
Lines 4622 4621 -1
==========================================
- Hits 3178 3177 -1
Misses 1444 1444 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good we can accelerate the KKT creation on the GPU, I noticed too that this was one of our bottleneck.
I have only minor comments. As a general rule of thumb, I would be in favor of adopting a proper naming convention for the GPU kernels. I am trying to follow the guideline:
@kernel! _do_operation_kernel!(modified_args, @Const(constant_args))
but I would welcome any other better suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge!
This PR improves KKT System creation on GPUs.
For some parts, we've been calling CPU versions. We introduce native GPU code for them.