Added WorstCaseImpact

MadeiraData · Sep 15, 2024 · d6a950d · d6a950d
1 parent 997cc56
commit d6a950d
Show file tree

Hide file tree

Showing 13 changed files with 295 additions and 39 deletions.
diff --git a/SQLChecks/Auto Create Statistics is Off.sql b/SQLChecks/Auto Create Statistics is Off.sql
@@ -20,6 +20,7 @@
 			CheckId ,
 			Title ,
 			RequiresAttention ,
+			WorstCaseImpact ,
 			CurrentStateImpact ,
 			RecommendationEffort ,
 			RecommendationRisk ,
@@ -35,7 +36,26 @@
 					ELSE
 						1
 				END ,
-			CurrentStateImpact		= 3 ,	-- High
-			RecommendationEffort	= 1 ,	-- Low
-			RecommendationRisk		= 1 ,	-- Low
+			WorstCaseImpact			= 3 ,	-- High
+			CurrentStateImpact		=
+				CASE
+					WHEN @AdditionalInfo IS NULL
+						THEN 0	-- None
+					ELSE
+						3	-- High
+				END ,
+			RecommendationEffort	=
+				CASE
+					WHEN @AdditionalInfo IS NULL
+						THEN 0	-- None
+					ELSE
+						1	-- Low
+				END ,
+			RecommendationRisk		=
+				CASE
+					WHEN @AdditionalInfo IS NULL
+						THEN 0	-- None
+					ELSE
+						1	-- Low
+				END ,
 			AdditionalInfo			= @AdditionalInfo;
diff --git a/SQLChecks/Columns with the IMAGE, TEXT, or NTEXT Data Types.sql b/SQLChecks/Columns with the IMAGE, TEXT, or NTEXT Data Types.sql
@@ -144,6 +144,7 @@
 			CheckId ,
 			Title ,
 			RequiresAttention ,
+			WorstCaseImpact ,
 			CurrentStateImpact ,
 			RecommendationEffort ,
 			RecommendationRisk ,
@@ -159,6 +160,7 @@
 					ELSE
 						1
 				END ,
+			WorstCaseImpact			= 1 ,	-- Low
 			CurrentStateImpact		=
 				CASE
 					WHEN @NumberOfColumns = 0

diff --git a/SQLChecks/Databases not in the Same Compatibility Level as the Instance.sql b/SQLChecks/Databases not in the Same Compatibility Level as the Instance.sql
@@ -1,9 +1,17 @@
 
 		DECLARE
-			@InstanceCompatibilityLevel AS TINYINT;
+			@InstanceCompatibilityLevel	AS TINYINT ,
+			@NumberOfDatabases			AS INT;
 
 		SET @InstanceCompatibilityLevel = CAST (LEFT (CAST (SERVERPROPERTY ('ProductVersion') AS NVARCHAR(128)) , CHARINDEX (N'.' , CAST (SERVERPROPERTY ('ProductVersion') AS NVARCHAR(128))) - 1) AS TINYINT) * 10;
 
+		SELECT
+			@NumberOfDatabases = COUNT (*)
+		FROM
+			sys.databases
+		WHERE
+			[compatibility_level] != @InstanceCompatibilityLevel;
+
 		SET @AdditionalInfo =
 			(
 				SELECT
@@ -25,6 +33,7 @@
 			CheckId ,
 			Title ,
 			RequiresAttention ,
+			WorstCaseImpact ,
 			CurrentStateImpact ,
 			RecommendationEffort ,
 			RecommendationRisk ,
@@ -40,7 +49,28 @@
 					ELSE
 						1
 				END ,
-			CurrentStateImpact		= 2 ,	-- Medium
-			RecommendationEffort	= 2 ,	-- Medium
-			RecommendationRisk		= 3 ,	-- Medium
+			WorstCaseImpact			= 2 ,	-- Medium
+			CurrentStateImpact		=
+				CASE
+					WHEN @NumberOfDatabases = 0
+						THEN 0	-- None
+					ELSE
+						2	-- Medium
+				END ,
+			RecommendationEffort	=
+				CASE
+					WHEN @NumberOfDatabases = 0
+						THEN 0	-- None
+					WHEN @NumberOfDatabases BETWEEN 1 AND 5
+						THEN 2	-- Medium
+					ELSE
+						3	-- High
+				END ,
+			RecommendationRisk		=
+				CASE
+					WHEN @NumberOfDatabases = 0
+						THEN 0	-- None
+					ELSE
+						2	-- Medium
+				END ,
 			AdditionalInfo			= @AdditionalInfo;
diff --git a/SQLChecks/Databases with Auto-Close Enabled.sql b/SQLChecks/Databases with Auto-Close Enabled.sql
@@ -20,6 +20,7 @@
 			CheckId ,
 			Title ,
 			RequiresAttention ,
+			WorstCaseImpact ,
 			CurrentStateImpact ,
 			RecommendationEffort ,
 			RecommendationRisk ,
@@ -35,9 +36,28 @@
 					ELSE
 						1
 				END ,
-			CurrentStateImpact		= 1 ,	-- Low
-			RecommendationEffort	= 1 ,	-- Low
-			RecommendationRisk		= 1 ,	-- Low
+			WorstCaseImpact			= 1 ,	-- Low
+			CurrentStateImpact		=
+				CASE
+					WHEN @AdditionalInfo IS NULL
+						THEN 0
+					ELSE
+						1	-- Low
+				END ,
+			RecommendationEffort	=
+				CASE
+					WHEN @AdditionalInfo IS NULL
+						THEN 0
+					ELSE
+						1	-- Low
+				END ,
+			RecommendationRisk		=
+				CASE
+					WHEN @AdditionalInfo IS NULL
+						THEN 0
+					ELSE
+						1	-- Low
+				END ,
 			AdditionalInfo			= @AdditionalInfo;
 
 		BREAK;
diff --git a/SQLChecks/Databases with Auto-Shrink Enabled.sql b/SQLChecks/Databases with Auto-Shrink Enabled.sql
@@ -20,6 +20,7 @@
 			CheckId ,
 			Title ,
 			RequiresAttention ,
+			WorstCaseImpact ,
 			CurrentStateImpact ,
 			RecommendationEffort ,
 			RecommendationRisk ,
@@ -35,9 +36,28 @@
 					ELSE
 						1
 				END ,
-			CurrentStateImpact		= 1 ,	-- Low
-			RecommendationEffort	= 1 ,	-- Low
-			RecommendationRisk		= 1 ,	-- Low
+			WorstCaseImpact			= 1 ,	-- Low
+			CurrentStateImpact		=
+				CASE
+					WHEN @AdditionalInfo IS NULL
+						THEN 0
+					ELSE
+						1	-- Low
+				END ,
+			RecommendationEffort	=
+				CASE
+					WHEN @AdditionalInfo IS NULL
+						THEN 0
+					ELSE
+						1	-- Low
+				END ,
+			RecommendationRisk		=
+				CASE
+					WHEN @AdditionalInfo IS NULL
+						THEN 0
+					ELSE
+						1	-- Low
+				END ,
 			AdditionalInfo			= @AdditionalInfo;
 
 		BREAK;
diff --git a/SQLChecks/Heap Tables.sql b/SQLChecks/Heap Tables.sql
@@ -1,7 +1,8 @@
 
 		DECLARE
 			@DatabaseName	AS SYSNAME ,
-			@Command		AS NVARCHAR(MAX);
+			@Command		AS NVARCHAR(MAX) ,
+			@NumberOfTables	AS INT;
 
 		DROP TABLE IF EXISTS
 			#HeapTables;
@@ -127,6 +128,11 @@
 
 		DEALLOCATE DatabasesCursor;
 
+		SELECT
+			@NumberOfTables = COUNT (*)
+		FROM
+			#HeapTables;
+
 		SET @AdditionalInfo =
 			(
 				SELECT
@@ -161,6 +167,7 @@
 			CheckId ,
 			Title ,
 			RequiresAttention ,
+			WorstCaseImpact ,
 			CurrentStateImpact ,
 			RecommendationEffort ,
 			RecommendationRisk ,
@@ -176,9 +183,30 @@
 					ELSE
 						1
 				END ,
-			CurrentStateImpact		= 2 ,	-- Medium
-			RecommendationEffort	= 3 ,	-- High
-			RecommendationRisk		= 3 ,	-- High
+			WorstCaseImpact			= 2 ,	-- Medium
+			CurrentStateImpact		=
+				CASE
+					WHEN @NumberOfTables = 0
+						THEN 0	-- None
+					ELSE
+						2	-- Medium
+				END ,
+			RecommendationEffort	=
+				CASE
+					WHEN @NumberOfTables = 0
+						THEN 0	-- None
+					WHEN @NumberOfTables BETWEEN 1 AND 5
+						THEN 2	-- Medium
+					ELSE
+						3	-- High
+				END ,
+			RecommendationRisk		=
+				CASE
+					WHEN @NumberOfTables = 0
+						THEN 0	-- None
+					ELSE
+						3	-- High
+				END ,
 			AdditionalInfo			= @AdditionalInfo;
 
 		DROP TABLE

diff --git a/SQLChecks/Indexes with High Fragmentation.sql b/SQLChecks/Indexes with High Fragmentation.sql
@@ -1,7 +1,8 @@
 
 		DECLARE
-			@DatabaseName	AS SYSNAME ,
-			@Command		AS NVARCHAR(MAX);
+			@DatabaseName		AS SYSNAME ,
+			@Command			AS NVARCHAR(MAX) ,
+			@NumberOfIndexes	AS INT;
 
 		DROP TABLE IF EXISTS
 			#FragmentedIndexes;
@@ -103,6 +104,12 @@
 
 		DEALLOCATE DatabasesCursor;
 
+		SELECT
+			@NumberOfIndexes = COUNT (*)
+		FROM
+			#FragmentedIndexes;
+
+
 		SET @AdditionalInfo =
 			(
 				SELECT
@@ -139,6 +146,7 @@
 			CheckId ,
 			Title ,
 			RequiresAttention ,
+			WorstCaseImpact ,
 			CurrentStateImpact ,
 			RecommendationEffort ,
 			RecommendationRisk ,
@@ -154,9 +162,30 @@
 					ELSE
 						1
 				END ,
-			CurrentStateImpact		= 2 ,	-- Medium
-			RecommendationEffort	= 1 ,	-- Low
-			RecommendationRisk		= 2 ,	-- Medium
+			WorstCaseImpact			= 2 ,	-- Medium
+			CurrentStateImpact		=
+				CASE
+					WHEN @NumberOfIndexes = 0
+						THEN 0	-- None
+					WHEN @NumberOfIndexes BETWEEN 1 AND 10
+						THEN 1	-- Low
+					ELSE
+						2	-- Medium
+				END ,
+			RecommendationEffort	=
+				CASE
+					WHEN @NumberOfIndexes = 0
+						THEN 0	-- None
+					ELSE
+						1	-- Low
+				END ,
+			RecommendationRisk		=
+				CASE
+					WHEN @NumberOfIndexes = 0
+						THEN 0	-- None
+					ELSE
+						2	-- Medium
+				END ,
 			AdditionalInfo			= @AdditionalInfo;
 
 		DROP TABLE

diff --git a/SQLChecks/Max Memory Configuration Too High.sql b/SQLChecks/Max Memory Configuration Too High.sql
@@ -74,6 +74,7 @@
 			CheckId ,
 			Title ,
 			RequiresAttention ,
+			WorstCaseImpact ,
 			CurrentStateImpact ,
 			RecommendationEffort ,
 			RecommendationRisk ,
@@ -89,9 +90,28 @@
 					ELSE
 						0
 				END ,
-			CurrentStateImpact		= 2 ,	-- Medium
-			RecommendationEffort	= 1 ,	-- Low
-			RecommendationRisk		= 1 ,	-- Low
+			WorstCaseImpact			= 2 ,	-- Medium
+			CurrentStateImpact		=
+				CASE
+					WHEN @CurrentMaxMemorySetting_MB > @RecommendedMaxMemorySetting_MB
+						THEN 2	-- Medium
+					ELSE
+						0	-- None
+				END ,
+			RecommendationEffort	=
+				CASE
+					WHEN @CurrentMaxMemorySetting_MB > @RecommendedMaxMemorySetting_MB
+						THEN 1	-- Low
+					ELSE
+						0	-- None
+				END ,
+			RecommendationRisk		=
+				CASE
+					WHEN @CurrentMaxMemorySetting_MB > @RecommendedMaxMemorySetting_MB
+						THEN 1	-- Low
+					ELSE
+						0	-- None
+				END ,
 			AdditionalInfo			= @AdditionalInfo;
 
 		BREAK;