-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Player Debug UI + fixes for debug stuffs #47
Conversation
SetScale needs to remain Vector3 as it's defined by the Framework itself, MafiaMP specifically can just rely on either X,Y,Z value to uniformly scale an object or use its own field in netcode for that.
See #45
server is not aware of supported vehicles. Back in LH-MP we would have a whitelist of supported model names, but I do not think it's appropriate these days, let's consider it a user error if modder tries to spawn a non-existent vehicle, because from server's POV nothing forbids it to do so. |
I've requested a few changes, otherwise the whole idea looks good. We should avoid introducing new ways-of-doing in term of codestyle, and also avoid breaking code consistency. |
Couldn't we just detect if the server created the vehicle or not? not necessarily a validation of the model in itself. |
but server always creates the vehicle, it will always succeed to do so. |
ff7ef1d
to
7c90094
Compare
Main
Also
sdk/entities/human/c_human_script.h
insdk/entities/c_human_2.h
(cleanup files which import both)sdk/entities/c_human_2.h
import whensdk/entities/c_player_2.h
is already importedC_HumanScript::GetInvulnerabilityByScript
C_PlayerTeleportModule::TeleportPlayer
known parametersC_Human2::IsInCoverFull
C_HumanWeaponController::DoWeaponSelectByItemId
Known issues
SetScale
needs a single float butGetScale
returns aVector3
=> Override JS player/vehicle GetScale/SetScale methods to only use scalar float #49Player.addWeapon
doesn't works => Fix Player.addWeapon JS built-in #51SDK Player.setPosition doesn't works in the event playerConnected => SDK::GetPlayerTeleportModule()->TeleportPlayer fails to teleport local player #45SDK chatargs[0]
is the command name when there is no args => Fix incorrect handling of arguments in chatCommand event #50sdk.World.createVehicle
returns an object even when the vehicle doesn't existsI will create specific tickets for these issues.