Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron tests #3684

Merged
merged 2 commits into from
Jan 8, 2025
Merged

electron tests #3684

merged 2 commits into from
Jan 8, 2025

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Jan 5, 2025

fixes running tests locally without labwc installed

follow up to #3680

@khassel khassel requested a review from rejas January 5, 2025 21:50
@sdetweil
Copy link
Collaborator

sdetweil commented Jan 5, 2025

I pulled this pr, and still see problems launching electron

npm run test:electron

  Development console tests
    ✕ should open browserwindow and dev console (772 ms)

  ● Electron app environment › should open browserwindow

    electron.launch: Process failed to launch!

      21 | 	}
      22 |
    > 23 | 	global.electronApp = await electron.launch({ args: electronParams });
         | 	                     ^
      24 |
      25 | 	await global.electronApp.firstWindow();
      26 |

      at Object.<anonymous>.exports.startApplication (tests/electron/helpers/global-setup.js:23:23)
      at Object.<anonymous> (tests/electron/env_spec.js:6:3)

  ● Development console tests › should open browserwindow and dev console

cal tests fail too
I did a new npm install , on node 20.18.1

@khassel
Copy link
Collaborator Author

khassel commented Jan 5, 2025

and npm start works?

@sdetweil
Copy link
Collaborator

sdetweil commented Jan 5, 2025

yes without problem

@khassel
Copy link
Collaborator Author

khassel commented Jan 5, 2025

is DISPLAY variable set?

Will convert to draft and test on an xserver system ...

@khassel khassel marked this pull request as draft January 5, 2025 22:36
@sdetweil
Copy link
Collaborator

sdetweil commented Jan 5, 2025 via email

@khassel
Copy link
Collaborator Author

khassel commented Jan 5, 2025

@sdetweil can you please check again with last changes, thx!

@sdetweil
Copy link
Collaborator

sdetweil commented Jan 5, 2025

browser starting, electron test successful!!

@khassel khassel marked this pull request as ready for review January 5, 2025 23:07
@khassel khassel requested review from rejas and removed request for rejas January 7, 2025 17:38
@rejas rejas merged commit 553d2d4 into MagicMirrorOrg:develop Jan 8, 2025
12 checks passed
@khassel khassel deleted the electron_tests branch January 13, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants