Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to electron v34 #3699

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Jan 15, 2025

related to #3593

  • electron-rebuild fails in our tests with electron v33 and v34 because nan must be fixed
  • there is an open PR from Okt. 24 which is still unmerged
  • comment from this issue: You should not ping nan maintainers as they have been quick to point out that they do not support and have no intention to support Electron in the future.
  • in above issue a fix is mentioned to get nan running which I have included in this PR to get the tests running
  • the currently used electron v32 has end of support 04 Mar 2025
  • we don't have to merge this now, we can wait until March for a decision how to progress

@bugsounet
Copy link
Contributor

You should not ping nan maintainers as they have been quick to point out that they do not support and have no intention to support Electron in the future.

Je pense que le test n'est plus nécessaire si le package n'est plus maintenu.
C'est a la team de @electron/rebuild de trouver une solution de remplacement et non a la team de MagicMirror².

Il n'y a donc pas de question a se poser, nous allons pas attendre éternellement !
De plus ce package n'est pas utiliser dans le core de MagicMirror². Il est exclusivement utiliser dans quelques modules tiers.
De plus, node-libgpiod est utiliser exclusivement par moi même.
Je suis capable d'oublier celle-ci et de travailler sans :)

@sdetweil
Copy link
Collaborator

does this close #3640?

@khassel
Copy link
Collaborator Author

khassel commented Jan 20, 2025

does this close #3640?

it would (skipping v33)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants