Skip to content

Commit

Permalink
Fix httptools.__all__
Browse files Browse the repository at this point in the history
While looking at #52, I noticed that `httptools.__all__` is incorrect
and doesn't actually include everything that is exported by the module,
which might entice the users to import from the private submodule
directly.

Fixes: #52
  • Loading branch information
elprans committed Feb 29, 2020
1 parent 354297a commit 9340d32
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
4 changes: 2 additions & 2 deletions httptools/__init__.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from .parser import parser
from . import parser
from .parser import * # NOQA

from ._version import __version__ # NOQA

__all__ = parser.__all__ # NOQA
__all__ = parser.__all__ + ('__version__',) # NOQA
7 changes: 3 additions & 4 deletions httptools/parser/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from .parser import *
from .errors import *
from .parser import * # NoQA
from .errors import * # NoQA


__all__ = parser.__all__ + errors.__all__
__all__ = parser.__all__ + errors.__all__ # NoQA

0 comments on commit 9340d32

Please sign in to comment.