Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic dark theme #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add basic dark theme #69

wants to merge 2 commits into from

Conversation

babbitt
Copy link

@babbitt babbitt commented Jan 28, 2024

Howdy! Heard about mailta.pe through prose.io and have been listening ever since.
Not the worlds greatest contribution but thought I would throw in a quick dark mode theme. I'm not sure it's 100% bullet proof as I was hunting down classes due to the nature of the project layout but it seems to work well visually confirming.

Light Dark
image image image image

I also added some accessibility changes in which occur on both versions of the site:

  • Added a stroke behind the white text on the episode page so that it's easier read on images with lighter backgrounds
  • Darker text on Vibrant backgrounds since white on bright yellow can be hard to read

Of course feedback on any of this or changes is always welcome.

Thanks for putting together high quality tapes every week!

@ImaCrea
Copy link
Member

ImaCrea commented Feb 19, 2024

Hi @babbitt thanks for this awesome contribution ! And sorry for the delay of my answer 😅

As I'm in the process of rewriting all to switch from Jekyll to Astro, I'm not sure how this is gonna work out. I'm planning also to switch from Bootstrap to Tailwind on the CSS side. So maybe let's wait for it to be in production (expect 1-2 months) and then we see how this PR needs to be updated eventually. 🤔

Cool for you?

A thousands thanks again for your contribution 💫 This is extremely cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants