Fix TOC and Google Play upload issues [Issue #37] #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kietyo
changed the title
|
Thanks for taking the time on fixing the issue! It would be nice if you can fix the following issues and resubmit the pull request:
Please refrain from changing the formatting without the approval of the repository maintainers. While there isn't a style guide for this project don't change the code of other people without a good reason.
Change the commit messages to something meaningful "save for now" is not a good commit message. Also you can reference issues with #isssue_number.
This makes it hard to review and track changes. Especially if it serves no purpose at all. These are some general tips you should keep in mind if you're contributing to pubic repositories ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes TOC so that it works with Microsoft Edge as well as Google Play Books. It also fixes the upload issues for Google Play Books.
I fixed the Google Play books stuff by reverse engineering from a epub book that I already knew works with Google Play Books.
These commits also have changes that occurred when I ran "Reformat Code" in the PyCharm IDE that I used.