Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LineModel.connections()->LineModel.edges() #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AsnelChristian
Copy link
Collaborator

First patch

@Makman2
Copy link
Owner

Makman2 commented Jun 9, 2017

MInd to close the issue inside the commit via a Closes xxxx reference?
Like coala I also like tags in commits ;) I think

LineModel: Rename connections() to edges()

as shortlog would fit pretty well.

I'm not so strict with shortlogs having only 50 chars max btw, I allow 72 like in the commit body. Usually you can write way better shortlogs if you have more space than 50 chars, especially when using tags ;)

@AsnelChristian
Copy link
Collaborator Author

done :)

@AsnelChristian AsnelChristian force-pushed the master branch 2 times, most recently from 0d60e99 to e4d1643 Compare June 9, 2017 17:36
@Makman2
Copy link
Owner

Makman2 commented Jul 29, 2017

Can still see some occurrences of connections :)

 mak  ~  dev  CE3D2   asnel/edge-rename  git grep -n connections
CE3D2/models/LineModel.h:13:    /// connections between single vectors.
CE3D2/models/LineModel.h:24:        /// vectors without connections.
CE3D2/models/LineModel.h:62:        /// define the line-connections of the model between the vectors.
CE3D2/models/LineModel.h:70:        /// define the line-connections of the model between the vectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants