Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixnum
has been deprecated for a while, it has finally been dropped.I am not totally sure of the implications here.
This will essentially change the wire protocol.
In theory, we could leave the code as-is.
The references to
Fixnum
are not ruby, but rather just in xml. and we are usingvalue.to_i
locally.But grep wise, would be nice for
grep Fixnum
to come back empty.Which is a non-trivial statement.
Very hard to manage a migration when there are false positives all around.