Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Fixnum #558

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Avoid Fixnum #558

merged 2 commits into from
Oct 21, 2024

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Sep 24, 2024

Fixnum has been deprecated for a while, it has finally been dropped.

I am not totally sure of the implications here.
This will essentially change the wire protocol.

In theory, we could leave the code as-is.
The references to Fixnum are not ruby, but rather just in xml. and we are using value.to_i locally.

But grep wise, would be nice for grep Fixnum to come back empty.
Which is a non-trivial statement.
Very hard to manage a migration when there are false positives all around.

@kbrock
Copy link
Member Author

kbrock commented Oct 2, 2024

kicking

@kbrock kbrock closed this Oct 2, 2024
@kbrock kbrock reopened this Oct 2, 2024
@Fryguy
Copy link
Member

Fryguy commented Oct 2, 2024

Is drb needed for fixnum? I'm confused how that's related.

@jrafanie
Copy link
Member

jrafanie commented Oct 2, 2024

Is drb needed for fixnum? I'm confused how that's related.

Sounds like something that was seen while playing around with this branch(last commit):

  warning: drb.rb was loaded from the standard library,
  but will no longer be part of the default gems starting from Ruby 3.4.0.
  You can add drb to your Gemfile or gemspec to silence this warning.

Seems like something we can extract and will need to do elsewhere but maybe there aren't much drb usages left so maybe it's just this. 🤞

```
  warning: drb.rb was loaded from the standard library,
  but will no longer be part of the default gems starting from Ruby 3.4.0.
  You can add drb to your Gemfile or gemspec to silence this warning.
```
@kbrock
Copy link
Member Author

kbrock commented Oct 18, 2024

update:

  • removing ruby 3.3 changes since this is good for all ruby implementations

@Fryguy Fryguy merged commit 5aff915 into ManageIQ:master Oct 21, 2024
3 checks passed
@Fryguy Fryguy assigned Fryguy and unassigned jrafanie Oct 21, 2024
@kbrock kbrock deleted the tainted_int branch October 21, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants