Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fix_token_expries_at to spec/support #851

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Move fix_token_expries_at to spec/support #851

merged 3 commits into from
Jun 6, 2023

Conversation

agrare
Copy link
Member

@agrare agrare commented Jun 6, 2023 •
edited
Loading

@agrare agrare requested a review from Fryguy as a code owner June 6, 2023 15:29
@agrare agrare mentioned this pull request Jun 6, 2023
Merged
1 task
Fryguy
Fryguy reviewed Jun 6, 2023
View reviewed changes
spec/support/vcr_helper.rb Outdated
@@ -0,0 +1,7 @@
def fix_token_expires_at(interaction)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to wrap this in a namespace of Spec::Support:VcrHelper for zeitwerk.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we'll need to fix the other files in spec/support/ as well then

@miq-bot
Copy link
Member

miq-bot commented Jun 6, 2023

Checked commits agrare/manageiq-providers-openstack@f5de6e7~...1f45d95 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@Fryguy Fryguy merged commit a31f0c8 into ManageIQ:master Jun 6, 2023
@Fryguy Fryguy self-assigned this Jun 6, 2023
@agrare agrare deleted the move_fix_expires_at_to_shared_helper branch June 6, 2023 20:12
@agrare agrare mentioned this pull request Jun 6, 2023
Merged
1 task
@Fryguy
Copy link
Member

Fryguy commented Jun 6, 2023

Backported to petrosian in commit fdc2838.

commit fdc283878bdf5d6738979c24842469ab7b97179f
Author: Jason Frey <[email protected]>
Date:   Tue Jun 6 16:11:55 2023 -0400

    Merge pull request #851 from agrare/move_fix_expires_at_to_shared_helper
    
    Move fix_token_expries_at to spec/support
    
    (cherry picked from commit a31f0c89c674cbaeded91f756bdc480971099723)

Fryguy added a commit that referenced this pull request Jun 6, 2023
@Fryguy
Merge pull request #851 from agrare/move_fix_expires_at_to_shared_helper
fdc2838 
Move fix_token_expries_at to spec/support

(cherry picked from commit a31f0c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy left review comments

Assignees

@Fryguy Fryguy

Labels
petrosian/backported refactoring test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrare @miq-bot @Fryguy