Merge pull request #1883 from Fryguy/target_blank

Add noopener noreferrer to blank targets (cherry picked from commit 89aa04e)
ManageIQ · Feb 7, 2024 · a5b4e52 · a5b4e52
1 parent 5e9e61a
commit a5b4e52
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/client/app/core/site-switcher/site-switcher.html b/client/app/core/site-switcher/site-switcher.html
@@ -4,7 +4,7 @@
   </button>
   <div uib-dropdown-menu class="uib-dropdown-menu uib-dropdown-menu-right" aria-labelledby="domain-switcher">
     <div ng-repeat="site in ctrl.sites" class="miq-siteswitcher-entry">
-      <a class="miq-siteswitcher-link" ng-href="{{site.url}}" target="_blank">
+      <a class="miq-siteswitcher-link" ng-href="{{site.url}}" target="_blank" rel="noopener noreferrer">
         <span title="{{site.tooltip}}" class="fa fa-3x" ng-class="site.iconClass"></span>
         <div>{{site.title}}</div>
       </a>

diff --git a/client/app/layouts/application.html b/client/app/layouts/application.html
@@ -50,12 +50,12 @@
           </a>
           <ul uib-dropdown-menu aria-labelledby="aboutModal">
             <li ng-if="vm.permissions.help.documentation">
-              <a href="{{vm.documentation}}" target="_blank">
+              <a href="{{vm.documentation}}" target="_blank" rel="noopener noreferrer">
                 {{ 'Documentation' | translate}}
               </a>
             </li>
             <li>
-              <a href="{{vm.about.supportWebsite}}" target="_new">
+              <a href="{{vm.about.supportWebsite}}" target="_blank" rel="noopener noreferrer">
                 {{vm.about.supportWebsiteText}}
               </a>
             </li>
@@ -117,4 +117,3 @@
     <div class="main-content" ui-view></div>
   </div>
 </div>
-