eslint - move to hierarchical configuration #10197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, we have no `.es6` files and no outstanding PRs introducing ones, and configuring eslint to base rules on file extensions is problematic so dropping this one for now, and we'll reintroduce when we move all *.js files to es6
…/javascripts/ specs will still inherit all the base rules, but additionally allow more spec-specific globals
files under components/, controllers/, directives/ and services/ will get additional angular-related rules applied to them (components/ is currently empty, but won't be for long..)
converted `var foo = {...}; module.exports = { foo: foo }` to `module.exports = { foo: {...} }`
because we no longer need it to be .js
|
Adding WIP for now, because with the latest, .. aah, "/home/himdel/manageiq/public/self_service/js/app-a1e38d0e6f.js" .. and node_modules and tmp .. and bower_components.. EDIT: fixed |
himdel
changed the title
to prevent eslint from crashing while trying to lint node_modules, self service bundles, etc
himdel
changed the title
|
Checked commits https://github.com/himdel/manageiq/compare/d9042ad0813b02019ac2ccdae9ab57b540a43594~...036d4f36b380188ff4228a0c64114cc8236a8894 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use different linting rules for angular and for specs, though most of it should indeed be shared.
Previously I solved this by running
eslint4 times, but that means an extra script, and having to merge the resulting JSON in miq-bot .. but eslint supports hierarchical configuration, precisely for those reason .. so this converts our.eslintrc.jsto a bunch of.eslintrc.jsonin the right directories..Also removing support for linting
.es6files for now.. but we don't have any.ManageIQ/miq_bot#221 will depend on this..