[WIP] Re-insert `MiqFileStorage` and `MiqFTPLib` v2 #19742

NickLaMuro · 2020-01-21T21:33:23Z

IMPORTANT PR STATUS UPDATE: See comment below.

With 100% more commit grafting!

This is a re-working of #19547 with the base commit being "grafted" to the commit that removed these files originally:

NickLaMuro@250a0b4

I will leave out most of the description to the previous PR, since this is mostly the same changes, with just a slightly different path of getting there.

Links

Original PR: Re-insert MiqFileStorage and MiqFTPLib #19547
Extraction point: NickLaMuro@250a0b4
Extra grafting steps: gist
Cross repo tests: Test alternate branch for ManageIQ/manageiq#19547 manageiq-cross_repo-tests#54
manageiq-gems-pending extraction PR: Extract MiqFileStorage and MiqFtpLib manageiq-gems-pending#454

TODO

Create a ManageIQ/manageiq-smartstate PR
Re-run the extraction with updated master, since it seems like some updates will be needed

*** Original Commit message shown below *** Author: Oleg Barenboim [email protected] Tue May 3 23:53:27 2016 -0500 Committer: Oleg Barenboim [email protected] Tue May 3 23:53:27 2016 -0500 Merge pull request ManageIQ#8404 from Ladas/fix_event_monitor_example_script Fix event_monitor_example.rb script (transferred from ManageIQ/manageiq-gems-pending@c0e7a76)

(transferred from ManageIQ/manageiq-gems-pending@2331b93)

Initial commit to support DB backups to S3. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1513520 (transferred from ManageIQ/manageiq-gems-pending@65ee189)

Based on PR review comments, use the existing MountSession "add" operation to upload the database file to S3. Correctly handle the situation where the bucket name requested exists but access is denied, indicating (probably) that is owned by another user. (The S3 namespace is Global - each user does not get their own a namespace). (transferred from ManageIQ/manageiq-gems-pending@67fd6ee)

The comment already mentioned that. (transferred from ManageIQ/manageiq-gems-pending@9966890)

`MiqFileStorage` is meant to be an top level class for fetching classes that interface with `MiqFileStorage::Interface`. `MiqFileStorage::Interface` is meant to be the super class for all of the class to inherit from, to make sure that they conform to a spec that `MiqFileStorage` can work with. (transferred from ManageIQ/manageiq-gems-pending@1c5c8c5)

(transferred from ManageIQ/manageiq-gems-pending@b716e29)

(transferred from ManageIQ/manageiq-gems-pending@e2e6494)

(transferred from ManageIQ/manageiq-gems-pending@e1b467b)

Changes to support restore of database from S3 objects. (transferred from ManageIQ/manageiq-gems-pending@7485a64)

Based on review comments change MiqS3Session.disconnect to self.raw_disconnect. Additionally remove the previously added 3rd argument to MiqGenericMountSession.add which is no longer needed. (transferred from ManageIQ/manageiq-gems-pending@60b37d0)

Force run umount if you forced run mount (transferred from ManageIQ/manageiq-gems-pending@0441a53)

This mount session is intended as being a pass through for when local files are used. The same API's for `#add` from MiqGenericMountSession are still usable for this class, and it will just write to the local file system instead. This also allows us to test the file splitting code without needing a mount session in place to do so. (transferred from ManageIQ/manageiq-gems-pending@1bd3433)

Context that make sure to spin up an FTP server when included, and will make some helper methods available. Uses the `ftpd` gem to handle the ftp server. (transferred from ManageIQ/manageiq-gems-pending@04552b0)

(transferred from ManageIQ/manageiq-gems-pending@aa9d9fb)

Support S3 for DB Backups (transferred from ManageIQ/manageiq-gems-pending@c505ace)

Since this is going to be overwritten in each class (most likely), and already is for S3, it makes sense that we don't include this since it doesn't do anything by being here. (transferred from ManageIQ/manageiq-gems-pending@9f91d86)

This is the top level class for Object Storage based file storages, which will include types like s3 and FTP. Doesn't do much, but shared methods between all of the Object Storage classes will be put here. (transferred from ManageIQ/manageiq-gems-pending@d79deab)

This is lifted from the FileDepotFtp code in the manageiq repo, and is just some shared methods around connecting to an FTP endpoint. Adds some tests around it as well. (transferred from ManageIQ/manageiq-gems-pending@25baa0b)

S3 db restore (transferred from ManageIQ/manageiq-gems-pending@7e8528b)

This was originally part of the MiqLocalMountSession spec, and could be useful for other specs as well, specifically FTP based object stores in the future. (transferred from ManageIQ/manageiq-gems-pending@f272e2e)

Converts MiqS3Session to an MiqObjectStorage subclass, MiqS3Storage. A decent amount here didn't change, but it updates the `#add` and `#download` methods to use the MiqFileStorage::Interface and instead override `#upload_single` and `#download_single`. Many of the tests didn't make it over since a lot of it was in regards to "mounting", which ObjectStorage classes don't do and is now obsolete, as well as cleaned up MiqGenericMountSession from any references that were s3 specific. Also dried up the code a bit from what was implemented in MiqS3Session. Regarding the elephant in the room... ------------------------------------- Yes, I backported Aws::S3::MultipartStreamUploader from the v3 portion of the aws-sdk as part of this commit. Some form of "upload streaming" was necessary for file splitting to work. I could have implemented something myself with probably a little less code, but what was already part of the v3 API, is probably tested extensively, and works with the v2 Seahorse client and lib made more sense to implement via this way instead of trying to role my own. It is a lot of extra code, but I have a flag in place for when we do upgrade to aws-sdk v3 in the future, an error should be raised in the test suite to have this patch removed. (transferred from ManageIQ/manageiq-gems-pending@f3e3e9c)

Adds MiqFtpLib (transferred from ManageIQ/manageiq-gems-pending@b6ca5f0)

This adds FTP as a ObjectStorage target, which allows the FTP protocol to be used in conjunction with the MiqFileStorage::Interface. Most of this is pretty straight forward and uses the vanilla Net::FTP mechanics, but upload_single got a bit involved. Because we want to stream as much of this content as possible, and file splitting is also a requirement for uploads, breaking into the internals of Net::FTP was necessary to achieve uploads where we were only partially reading the input. `Net::FTP#storbinary` only allows sending the entire file, and being able to specify the size of the upload chunks and offset, but not how much of the file intotal to send. IO.copy_stream thankfully does most of the heavy lifting and logic for us, and since we are streaming the content through that, should send the `.write` calls in a small enough size that doesn't go over the `Net::FTP::DEFAULT_BLOCKSIZE`... I hope... (transferred from ManageIQ/manageiq-gems-pending@11346b9)

…ad_target_abstractions MiqFileStorage interface and subclassing (with file splitting) (transferred from ManageIQ/manageiq-gems-pending@7ba5665)

Add an Openstack Swift session object to allow backups to Swift. (transferred from ManageIQ/manageiq-gems-pending@ecf715f)

S3 was moved over to the object file session rather than this mount session subclass by a separate PR, so adding it back in via this PR is incorrect and causes Travis build failures. (transferred from ManageIQ/manageiq-gems-pending@5c3ebdc)

Removing the swift class for the Mount Session, and adding a new swift class for Object Storage instead. This works with the streaming db backups/dumps now implemented. (transferred from ManageIQ/manageiq-gems-pending@f3a3f05)

As per review comment don't use $fog_log here. (transferred from ManageIQ/manageiq-gems-pending@aa8f839)

Review comments by various reviews. Some nitpicks but the major change is to not use Openstack Provider handle code but instead use Fog::Openstack. (transferred from ManageIQ/manageiq-gems-pending@49ccf0f)

Removes some unneeded lines, and unnecessary words in `it` lines. (transferred from ManageIQ/manageiq-gems-pending@354d08f)

@ftp

Since we need a connection for any download/upload to work (sets @ftp on the instance), we need a slight override of `#magic_number_for` to wrap it with a connection. (transferred from ManageIQ/manageiq-gems-pending@f70c48d)

…o-swift-object-store Add MiqSwiftStorage#download_single (transferred from ManageIQ/manageiq-gems-pending@1525c2c)

If there is no trailing slash in the parsed out `path` from `URI.parse`, then setting of `@container_name` didn't match the regexp, and so it caused the path generated for the URL in the `#container` method to generate as: "/v1/AUTH_asdfglkjwearimsdf/%2Fcontainer_name" Instead of: "/v1/AUTH_asdfglkjwearimsdf/container_name" Where `"%2f"` is due to `fog-core`'s URI escaping code of the string passed into the `swift.directories.get(container_name)` when it includes a slash (so `"/container_name" => "%2Fcontainer_name"`). The fix makes sure the regexp is correct, and the removal of the extra `\/` check at the end was removed. Some extra tests were put in place to make sure everything still works as expected. (transferred from ManageIQ/manageiq-gems-pending@242bf6f)

…to-miq-file-storage [MiqFileStorage] Add #magic_number_for (transferred from ManageIQ/manageiq-gems-pending@b3f99e1)

(transferred from ManageIQ/manageiq-gems-pending@f0a5d5a)

…ngle Fixes to swift storage (transferred from ManageIQ/manageiq-gems-pending@d241557)

Does better fallback handling and nil checking for this method. This can fail as part of `MiqGenericMountSession#add`'s `rescue` statement when the `@source_input` is not defined, and that will mask the actual error that was raised. This fixes that bug so the proper error is shown in the logs. (transferred from ManageIQ/manageiq-gems-pending@7f8b69a)

update aws-sdk gem to v3 (transferred from ManageIQ/manageiq-gems-pending@f92379b)

…rors [MiqGenericMountSession] Fix .source_for_log (transferred from ManageIQ/manageiq-gems-pending@bb0b1d4)

…d_ftp_libs_grafted

Since this has been moved from `manageiq-gems-pending`, this is no longer needed, and keeping it in causes the build to fail.

- Adds ignore cases for two items that have been there for a bit - Removes an outdated warning.

This is used by the `MiqFtpLib` specs

miq-bot · 2020-01-21T21:47:04Z

Some comments on commits NickLaMuro/manageiq@75ef1b6~...8820a90

spec/support/examples_group/with_ftp_server.rb

⚠️ - 15 - Detected puts. Remove all debugging statements.
⚠️ - 53 - Detected puts. Remove all debugging statements.

miq-bot · 2020-01-21T21:47:05Z

Some comments on commits NickLaMuro/manageiq@75ef1b6~...8820a90

spec/support/examples_group/with_ftp_server.rb

⚠️ - 15 - Detected puts. Remove all debugging statements.
⚠️ - 53 - Detected puts. Remove all debugging statements.

miq-bot · 2020-01-21T21:47:20Z

Checked commits NickLaMuro/manageiq@75ef1b6~...8820a90 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
25 files checked, 115 offenses detected

lib/miq_file_storage.rb

❗ - Line 120, Col 7 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.
❗ - Line 187, Col 15 - Layout/ExtraSpacing - Unnecessary spacing detected.
❗ - Line 187, Col 19 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
❗ - Line 191, Col 9 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.
❗ - Line 276, Col 11 - Style/RedundantBegin - Redundant begin block detected.
❗ - Line 54, Col 23 - Style/MutableConstant - Freeze mutable objects assigned to constants.

lib/miq_ftp_lib.rb

❗ - Line 44, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
❗ - Line 60, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
❗ - Line 67, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

lib/miq_object_storage.rb

❗ - Line 15, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
❗ - Line 28, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
❗ - Line 42, Col 7 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

lib/mount/miq_generic_mount_session.rb

lib/mount/miq_glusterfs_session.rb

⚠️ - Line 16, Col 17 - Lint/UriEscapeUnescape - URI.encode method is obsolete and should not be used. Instead, use CGI.escape, URI.encode_www_form or URI.encode_www_form_component depending on your specific use case.
❗ - Line 25, Col 116 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

lib/mount/miq_nfs_session.rb

⚠️ - Line 15, Col 13 - Lint/UselessAssignment - Useless assignment to variable - userinfo. Use _ or _userinfo as a variable name to indicate that it won't be used.
⚠️ - Line 15, Col 30 - Lint/UselessAssignment - Useless assignment to variable - port. Use _ or _port as a variable name to indicate that it won't be used.
⚠️ - Line 15, Col 36 - Lint/UselessAssignment - Useless assignment to variable - registry. Use _ or _registry as a variable name to indicate that it won't be used.
⚠️ - Line 15, Col 5 - Lint/UselessAssignment - Useless assignment to variable - scheme. Use _ or _scheme as a variable name to indicate that it won't be used.
⚠️ - Line 15, Col 59 - Lint/UselessAssignment - Useless assignment to variable - opaque. Use _ or _opaque as a variable name to indicate that it won't be used.
⚠️ - Line 15, Col 67 - Lint/UselessAssignment - Useless assignment to variable - query. Use _ or _query as a variable name to indicate that it won't be used.
⚠️ - Line 15, Col 74 - Lint/UselessAssignment - Useless assignment to variable - fragment. Use _ or _fragment as a variable name to indicate that it won't be used.
⚠️ - Line 15, Col 95 - Lint/UriEscapeUnescape - URI.encode method is obsolete and should not be used. Instead, use CGI.escape, URI.encode_www_form or URI.encode_www_form_component depending on your specific use case.
❗ - Line 4, Col 11 - Style/MutableConstant - Freeze mutable objects assigned to constants.

lib/mount/miq_smb_session.rb

⚠️ - Line 17, Col 13 - Lint/UselessAssignment - Useless assignment to variable - userinfo. Use _ or _userinfo as a variable name to indicate that it won't be used.
⚠️ - Line 17, Col 30 - Lint/UselessAssignment - Useless assignment to variable - port. Use _ or _port as a variable name to indicate that it won't be used.
⚠️ - Line 17, Col 36 - Lint/UselessAssignment - Useless assignment to variable - registry. Use _ or _registry as a variable name to indicate that it won't be used.
⚠️ - Line 17, Col 5 - Lint/UselessAssignment - Useless assignment to variable - scheme. Use _ or _scheme as a variable name to indicate that it won't be used.
⚠️ - Line 17, Col 59 - Lint/UselessAssignment - Useless assignment to variable - opaque. Use _ or _opaque as a variable name to indicate that it won't be used.
⚠️ - Line 17, Col 67 - Lint/UselessAssignment - Useless assignment to variable - query. Use _ or _query as a variable name to indicate that it won't be used.
⚠️ - Line 17, Col 74 - Lint/UselessAssignment - Useless assignment to variable - fragment. Use _ or _fragment as a variable name to indicate that it won't be used.
⚠️ - Line 17, Col 95 - Lint/UriEscapeUnescape - URI.encode method is obsolete and should not be used. Instead, use CGI.escape, URI.encode_www_form or URI.encode_www_form_component depending on your specific use case.
❗ - Line 4, Col 11 - Style/MutableConstant - Freeze mutable objects assigned to constants.

lib/object_storage/miq_ftp_storage.rb

❗ - Line 64, Col 9 - Style/RedundantBegin - Redundant begin block detected.
❗ - Line 70, Col 11 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.

lib/object_storage/miq_swift_storage.rb

⚠️ - Line 19, Col 94 - Lint/UriEscapeUnescape - URI.encode method is obsolete and should not be used. Instead, use CGI.escape, URI.encode_www_form or URI.encode_www_form_component depending on your specific use case.
⚠️ - Line 33, Col 41 - Lint/UriEscapeUnescape - URI.encode method is obsolete and should not be used. Instead, use CGI.escape, URI.encode_www_form or URI.encode_www_form_component depending on your specific use case.
❗ - Line 112, Col 22 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
❗ - Line 142, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.
❗ - Line 152, Col 40 - Layout/SpaceInsideHashLiteralBraces - Space inside { detected.
❗ - Line 152, Col 63 - Layout/SpaceInsideHashLiteralBraces - Space inside } detected.
❗ - Line 18, Col 5 - Layout/EmptyLineAfterGuardClause - Add empty line after guard clause.

spec/lib/miq_ftp_lib_spec.rb

❗ - Line 36, Col 5 - Style/PercentLiteralDelimiters - %w-literals should be delimited by [ and ].
❗ - Line 55, Col 24 - Layout/SpaceInsideHashLiteralBraces - Space inside { detected.
❗ - Line 55, Col 75 - Layout/SpaceInsideHashLiteralBraces - Space inside } detected.

spec/lib/mount/miq_local_mount_session_spec.rb

❗ - Line 105, Col 19 - Layout/SpaceInsideHashLiteralBraces - Space inside { detected.
❗ - Line 105, Col 62 - Layout/SpaceInsideHashLiteralBraces - Space inside } detected.

spec/lib/object_storage/miq_ftp_storage_spec.rb

❗ - Line 133, Col 19 - Layout/SpaceInsideHashLiteralBraces - Space inside { detected.
❗ - Line 133, Col 62 - Layout/SpaceInsideHashLiteralBraces - Space inside } detected.
❗ - Line 5, Col 22 - Layout/SpaceInsideHashLiteralBraces - Space inside { detected.
❗ - Line 5, Col 69 - Layout/SpaceInsideHashLiteralBraces - Space inside } detected.

spec/support/custom_matchers/exist_on_ftp_server.rb

❗ - Line 29, Col 7 - Style/RedundantBegin - Redundant begin block detected.

spec/support/custom_matchers/have_size_on_ftp_server_of.rb

❗ - Line 23, Col 7 - Style/RedundantBegin - Redundant begin block detected.

spec/support/examples_group/with_ftp_server.rb

❗ - Line 53, Col 5 - Naming/MemoizedInstanceVariableName - Memoized variable @existing_file does not match method name create_existing_file. Use @create_existing_file instead.
❗ - Line 58, Col 5 - Naming/MemoizedInstanceVariableName - Memoized variable @existing_dir does not match method name create_existing_dir. Use @create_existing_dir instead.
❗ - Line 81, Col 28 - Layout/SpaceInsideHashLiteralBraces - Space inside { detected.
❗ - Line 81, Col 75 - Layout/SpaceInsideHashLiteralBraces - Space inside } detected.

NickLaMuro · 2020-01-21T22:51:38Z

FYI to anyone stumbling across this:

We are probably going to table this for the time being since the manageiq-smartstate dependency is kind of gross, and having that depend on core just seems wrong, even if it is meant to be a short term solution.

Going to experiment with an alternative location for this code, but for right now, expect this to stay [WIP] while other options are explored.

miq-bot · 2020-05-07T12:55:24Z

This pull request is not mergeable. Please rebase and repush.

NickLaMuro · 2020-05-07T15:06:18Z

Since this just became unmergeable and #19742 (comment) why this most likely won't be used, going to close. Can always re-open if we change our minds.

NickLaMuro and others added 30 commits January 21, 2020 14:40

Move test directories to the root

d91a67c

(transferred from ManageIQ/manageiq-gems-pending@2331b93)

Support S3 for DB Backups

3e3550b

Initial commit to support DB backups to S3. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1513520 (transferred from ManageIQ/manageiq-gems-pending@65ee189)

If we run sudo for mount, we need to do the same for umount

6075f79

The comment already mentioned that. (transferred from ManageIQ/manageiq-gems-pending@9966890)

Review Comments

1c86595

(transferred from ManageIQ/manageiq-gems-pending@b716e29)

Do not decide upon failure message but command that was run

c34d389

(transferred from ManageIQ/manageiq-gems-pending@e2e6494)

Update MiqGenericMountSession to MiqFileStorage::Interface

d32a9d4

(transferred from ManageIQ/manageiq-gems-pending@e1b467b)

S3 Restore Support

33b5560

Changes to support restore of database from S3 objects. (transferred from ManageIQ/manageiq-gems-pending@7485a64)

PR Review Comments

aa430cc

Based on review comments change MiqS3Session.disconnect to self.raw_disconnect. Additionally remove the previously added 3rd argument to MiqGenericMountSession.add which is no longer needed. (transferred from ManageIQ/manageiq-gems-pending@60b37d0)

Merge pull request ManageIQ#74 from isimluk/use-sudo-for-umount

e5b2619

Force run umount if you forced run mount (transferred from ManageIQ/manageiq-gems-pending@0441a53)

Add with_ftp_server rspec shared_context

2d794b2

Context that make sure to spin up an FTP server when included, and will make some helper methods available. Uses the `ftpd` gem to handle the ftp server. (transferred from ManageIQ/manageiq-gems-pending@04552b0)

Remove supports_objects? based on Review Comments

e968263

(transferred from ManageIQ/manageiq-gems-pending@aa9d9fb)

Merge pull request ManageIQ#355 from jerryk55/s3_db_backup

485474f

Support S3 for DB Backups (transferred from ManageIQ/manageiq-gems-pending@c505ace)

Remove MiqObjectStorage.new_with_opts

13ff993

Since this is going to be overwritten in each class (most likely), and already is for S3, it makes sense that we don't include this since it doesn't do anything by being here. (transferred from ManageIQ/manageiq-gems-pending@9f91d86)

Add MiqObjectStore

7b831a0

This is the top level class for Object Storage based file storages, which will include types like s3 and FTP. Doesn't do much, but shared methods between all of the Object Storage classes will be put here. (transferred from ManageIQ/manageiq-gems-pending@d79deab)

Adds MiqFtpLib

1b22c0e

This is lifted from the FileDepotFtp code in the manageiq repo, and is just some shared methods around connecting to an FTP endpoint. Adds some tests around it as well. (transferred from ManageIQ/manageiq-gems-pending@25baa0b)

Merge pull request ManageIQ#357 from jerryk55/s3_db_restore

a97aeb7

S3 db restore (transferred from ManageIQ/manageiq-gems-pending@7e8528b)

Add "generated tmp files" context

e750f9d

This was originally part of the MiqLocalMountSession spec, and could be useful for other specs as well, specifically FTP based object stores in the future. (transferred from ManageIQ/manageiq-gems-pending@f272e2e)

Merge pull request ManageIQ#360 from NickLaMuro/miq_ftp_lib

963eabf

Adds MiqFtpLib (transferred from ManageIQ/manageiq-gems-pending@b6ca5f0)

Merge pull request ManageIQ#361 from NickLaMuro/file_storage_and_uplo…

4d90a4f

…ad_target_abstractions MiqFileStorage interface and subclassing (with file splitting) (transferred from ManageIQ/manageiq-gems-pending@7ba5665)

DB Backups to Openstack Swift

5639e20

Add an Openstack Swift session object to allow backups to Swift. (transferred from ManageIQ/manageiq-gems-pending@ecf715f)

Fix Travis Failure

e37e0bd

S3 was moved over to the object file session rather than this mount session subclass by a separate PR, so adding it back in via this PR is incorrect and causes Travis build failures. (transferred from ManageIQ/manageiq-gems-pending@5c3ebdc)

Swift DB Backup Support with MiqObjectStorage Methodology

e679876

Removing the swift class for the Mount Session, and adding a new swift class for Object Storage instead. This works with the streaming db backups/dumps now implemented. (transferred from ManageIQ/manageiq-gems-pending@f3a3f05)

Remove ref to $fog_log

7943183

As per review comment don't use $fog_log here. (transferred from ManageIQ/manageiq-gems-pending@aa8f839)

Review Comments

64c4f07

Review comments by various reviews. Some nitpicks but the major change is to not use Openstack Provider handle code but instead use Fog::Openstack. (transferred from ManageIQ/manageiq-gems-pending@49ccf0f)

NickLaMuro and others added 15 commits January 21, 2020 14:40

[MiqSwiftStorage] Spec cleanup

8a59edf

Removes some unneeded lines, and unnecessary words in `it` lines. (transferred from ManageIQ/manageiq-gems-pending@354d08f)

[MiqFtpStorage] Add #magic_number_for support

67eb4d0

Since we need a connection for any download/upload to work (sets @ftp on the instance), we need a slight override of `#magic_number_for` to wrap it with a connection. (transferred from ManageIQ/manageiq-gems-pending@f70c48d)

Merge pull request ManageIQ#400 from NickLaMuro/add-download-single-t…

d06fd57

…o-swift-object-store Add MiqSwiftStorage#download_single (transferred from ManageIQ/manageiq-gems-pending@1525c2c)

Merge pull request ManageIQ#401 from NickLaMuro/add-magic-number-for-…

bfe99c4

…to-miq-file-storage [MiqFileStorage] Add #magic_number_for (transferred from ManageIQ/manageiq-gems-pending@b3f99e1)

fix require statements

edcdc79

(transferred from ManageIQ/manageiq-gems-pending@f0a5d5a)

Merge pull request ManageIQ#410 from NickLaMuro/fix-swift-download-si…

9eaef92

…ngle Fixes to swift storage (transferred from ManageIQ/manageiq-gems-pending@d241557)

Merge pull request ManageIQ#449 from AlexanderZagaynov/aws_sdk_v3

2f857a6

update aws-sdk gem to v3 (transferred from ManageIQ/manageiq-gems-pending@f92379b)

Merge pull request ManageIQ#447 from NickLaMuro/fix_source_for_log_er…

314641d

…rors [MiqGenericMountSession] Fix .source_for_log (transferred from ManageIQ/manageiq-gems-pending@bb0b1d4)

Move lib/gems/pending/util/ to lib/

d76ed16

Merge remote-tracking branch 'upstream/master' into reinject_mount_an…

43f893e

…d_ftp_libs_grafted

[MiqFileStorage] Remove 'util/*' from requires

e472d01

Since this has been moved from `manageiq-gems-pending`, this is no longer needed, and keeping it in causes the build to fail.

Update brakeman.ignore for MiqObjectStorage

6f4d9a6

- Adds ignore cases for two items that have been there for a bit - Removes an outdated warning.

[Gemfile] Add ftpd to test dependencies

8820a90

This is used by the `MiqFtpLib` specs

miq-bot added wip dependencies labels Jan 21, 2020

NickLaMuro mentioned this pull request Jan 21, 2020

[WIP] Update require calls for mount libs ManageIQ/manageiq-smartstate#107

Closed

NickLaMuro mentioned this pull request Jan 21, 2020

Test alternate branch for ManageIQ/manageiq#19547 ManageIQ/manageiq-cross_repo-tests#54

Closed

mfeifer added the refactoring label Jan 23, 2020

mfeifer assigned Fryguy Jan 23, 2020

miq-bot added the unmergeable label May 7, 2020

NickLaMuro mentioned this pull request May 7, 2020

Re-insert MiqFileStorage and MiqFTPLib #19547

Closed

NickLaMuro closed this May 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Re-insert `MiqFileStorage` and `MiqFTPLib` v2 #19742

[WIP] Re-insert `MiqFileStorage` and `MiqFTPLib` v2 #19742

NickLaMuro commented Jan 21, 2020 •

edited

Loading

miq-bot commented Jan 21, 2020

miq-bot commented Jan 21, 2020

miq-bot commented Jan 21, 2020

NickLaMuro commented Jan 21, 2020

miq-bot commented May 7, 2020

NickLaMuro commented May 7, 2020

[WIP] Re-insert MiqFileStorage and MiqFTPLib v2 #19742

[WIP] Re-insert MiqFileStorage and MiqFTPLib v2 #19742

Conversation

NickLaMuro commented Jan 21, 2020 • edited Loading

Links

TODO

miq-bot commented Jan 21, 2020

miq-bot commented Jan 21, 2020

miq-bot commented Jan 21, 2020

NickLaMuro commented Jan 21, 2020

miq-bot commented May 7, 2020

NickLaMuro commented May 7, 2020

[WIP] Re-insert `MiqFileStorage` and `MiqFTPLib` v2 #19742

[WIP] Re-insert `MiqFileStorage` and `MiqFTPLib` v2 #19742

NickLaMuro commented Jan 21, 2020 •

edited

Loading