Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount messaging configuration on podified #22859

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nasark
Copy link
Member

@nasark nasark commented Jan 26, 2024

  • mount the necessary messaging configs from their respective secrets using a projected volume mount

Depends on:

@miq-bot assign @bdunne
@miq-bot add_reviewer @Fryguy
@miq-bot add_label enhancement, quinteros/yes?

@miq-bot
Copy link
Member

miq-bot commented Jan 26, 2024

Checked commit nasark@c070eae with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 7 offenses detected

lib/container_orchestrator/object_definition.rb

Comment on lines +70 to +73
{:key => "hostname", :path => "MESSAGING_HOSTNAME"},
{:key => "username", :path => "MESSAGING_USERNAME"},
{:key => "port", :path => "MESSAGING_PORT"},
{:key => "sasl_mechanism", :path => "MESSAGING_SASL_MECHANISM"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment seems off here.

@miq-bot miq-bot added the stale label Apr 29, 2024
@miq-bot
Copy link
Member

miq-bot commented Apr 29, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

2 similar comments
@miq-bot
Copy link
Member

miq-bot commented Aug 5, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Nov 11, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants