Poll more frequently in Ansible::Runner::ResponseAsync#wait #23230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is primarily used by tests, and it was noticed that most of the test cases complete in roughly 0.4s-0.9s in the normal case. Thus, polling more frequently every 0.1s seems to strike a nice balance. With this change, the tests seems to take on average 5s less time.
|
Checked commit Fryguy@467e1d5 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
agrare
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is primarily used by tests, and it was noticed that most of the test cases complete in roughly 0.4s-0.9s in the normal case. Thus, polling more frequently every 0.1s seems to strike a nice balance. With this change, the tests seems to take on average 5s less time.
@agrare Please review.