Removed unused variable "inspected_file_count"

Variable "inspected_file_count" in the result of the linters has been removed due to missing use. It was not used in the pull request comment describing the offenses detected by linters in the source code.

app/workers/concerns/code_analysis_mixin.rb

@@ -15,14 +15,13 @@ def merged_linter_results
     results = {
       "files"   => [],
       "summary" => {
-        "inspected_file_count" => 0,
-        "offense_count"        => 0,
-        "target_file_count"    => 0,
+        "offense_count"     => 0,
+        "target_file_count" => 0,
       },
     }
 
     run_all_linters.each do |result|
-      %w(offense_count target_file_count inspected_file_count).each do |m|
+      %w[offense_count target_file_count].each do |m|
         results['summary'][m] += result['summary'][m]
       end
       results['files'] += result['files']
@@ -70,9 +69,8 @@ def run_all_linters
       end
 
       output["summary"] = {
-        "offense_count"        => output["files"].sum { |item| item['offenses'].length },
-        "target_file_count"    => output["files"].length,
-        "inspected_file_count" => 0 # TODO: value cannot be obtained from the result of `pronto_result` method
+        "offense_count"     => output["files"].sum { |item| item['offenses'].length },
+        "target_file_count" => output["files"].length,
       }
 
       output

spec/support/rubocop_spec_helper.rb

@@ -4,7 +4,7 @@ def rubocop_results
     rubocop = JSON.parse(`rubocop --format=json --no-display-cop-names #{rubocop_check_path}`)
     hamllint = JSON.parse(`haml-lint --reporter=json #{rubocop_check_path}`)
 
-    %w(offense_count target_file_count inspected_file_count).each do |m|
+    %w[offense_count target_file_count].each do |m|
       rubocop['summary'][m] += hamllint['summary'][m]
     end
     rubocop['files'] += hamllint['files']

spec/workers/commit_monitor_handlers/commit_range/rubocop_checker/data/with_haml_file_using_haml-lint/results.json

@@ -21,7 +21,6 @@
   ],
   "summary": {
     "offense_count": 1,
-    "target_file_count": 1,
-    "inspected_file_count": 1
+    "target_file_count": 1
   }
-}
+}

spec/workers/commit_monitor_handlers/commit_range/rubocop_checker/data/with_lines_not_in_the_diff/results.json

@@ -39,7 +39,6 @@
   ],
   "summary": {
     "offense_count": 3,
-    "target_file_count": 1,
-    "inspected_file_count": 1
+    "target_file_count": 1
   }
-}
+}

spec/workers/commit_monitor_handlers/commit_range/rubocop_checker/data/with_results_generating_multiple_comments/results.json

@@ -2351,7 +2351,6 @@
   ],
   "summary": {
     "offense_count": 292,
-    "target_file_count": 1,
-    "inspected_file_count": 1
+    "target_file_count": 1
   }
-}
+}

spec/workers/commit_monitor_handlers/commit_range/rubocop_checker/data/with_results_with_no_offenses/results.json

@@ -16,7 +16,6 @@
   ],
   "summary": {
     "offense_count": 0,
-    "target_file_count": 1,
-    "inspected_file_count": 1
+    "target_file_count": 1
   }
 }

spec/workers/commit_monitor_handlers/commit_range/rubocop_checker/data/with_results_with_offenses/results.json

@@ -63,7 +63,6 @@
   ],
   "summary": {
     "offense_count": 4,
-    "target_file_count": 4,
-    "inspected_file_count": 4
+    "target_file_count": 4
   }
-}
+}

spec/workers/commit_monitor_handlers/commit_range/rubocop_checker/data/with_results_without_column_numbers_and_cop_names/results.json

@@ -21,7 +21,6 @@
   ],
   "summary": {
     "offense_count": 1,
-    "target_file_count": 1,
-    "inspected_file_count": 1
+    "target_file_count": 1
   }
-}
+}

spec/workers/commit_monitor_handlers/commit_range/rubocop_checker/data/with_void_warnings_in_spec_files/results.json

@@ -49,7 +49,6 @@
   ],
   "summary": {
     "offense_count": 3,
-    "target_file_count": 3,
-    "inspected_file_count": 3
+    "target_file_count": 3
   }
-}
+}

spec/workers/concerns/code_analysis_mixin_spec.rb

@@ -10,7 +10,7 @@
   describe "#merged_linter_results" do
     it "should always return a hash with a 'files' and 'summary' key, even with no cops running" do
       allow(subject).to receive(:pronto_result).and_return([])
-      expect(subject.merged_linter_results).to eq("files" => [], "summary" => {"inspected_file_count" => 0, "offense_count" => 0, "target_file_count" => 0})
+      expect(subject.merged_linter_results).to eq("files" => [], "summary" => {"offense_count" => 0, "target_file_count" => 0})
     end
   end
 
@@ -37,7 +37,7 @@
         expect(subject.run_all_linters).to eq(
           [
             {
-              "files"    => [
+              "files"   => [
                 {
                   "path"     => item_rubocop.path,
                   "offenses" => [
@@ -46,15 +46,14 @@
                       "message"   => item_rubocop.msg,
                       "cop_name"  => item_rubocop.runner,
                       "corrected" => false,
-                      "line"   => item_msg.line.position
+                      "line"      => item_msg.line.position
                     },
                   ]
                 }
               ],
-              "summary"  => {
-                "offense_count"        => input.group_by(&:runner).values[0].count,
-                "target_file_count"    => input.group_by(&:runner).values[0].group_by(&:path).count,
-                "inspected_file_count" => 0
+              "summary" => {
+                "offense_count"     => input.group_by(&:runner).values[0].count,
+                "target_file_count" => input.group_by(&:runner).values[0].group_by(&:path).count
               }
             },
             {
@@ -67,15 +66,14 @@
                       "message"   => item_haml.msg,
                       "cop_name"  => item_haml.runner,
                       "corrected" => false,
-                      "line"   => item_msg.line.position
+                      "line"      => item_msg.line.position
                     },
                   ]
                 }
               ],
               "summary" => {
-                "offense_count"        => input.group_by(&:runner).values[1].count,
-                "target_file_count"    => input.group_by(&:runner).values[1].group_by(&:path).count,
-                "inspected_file_count" => 0
+                "offense_count"     => input.group_by(&:runner).values[1].count,
+                "target_file_count" => input.group_by(&:runner).values[1].group_by(&:path).count
               }
             },
             {
@@ -88,15 +86,14 @@
                       "message"   => item_yaml.msg,
                       "cop_name"  => item_yaml.runner,
                       "corrected" => false,
-                      "line"   => item_msg.line.position
+                      "line"      => item_msg.line.position
                     },
                   ]
                 }
               ],
               "summary" => {
-                "offense_count"        => input.group_by(&:runner).values[2].count,
-                "target_file_count"    => input.group_by(&:runner).values[2].group_by(&:path).count,
-                "inspected_file_count" => 0
+                "offense_count"     => input.group_by(&:runner).values[2].count,
+                "target_file_count" => input.group_by(&:runner).values[2].group_by(&:path).count
               }
             }
           ]