Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Ruby 3.2 and 3.3 #123

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Add tests for Ruby 3.2 and 3.3 #123

merged 1 commit into from
Sep 3, 2024

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Sep 3, 2024

@jrafanie Please review.

@Fryguy Fryguy added the test label Sep 3, 2024
@Fryguy
Copy link
Member Author

Fryguy commented Sep 3, 2024 •
edited
Loading

@jrafanie Separately I noticed we haven't had a release in a long time, and one of my PRs I needed recently. I'm going to release a 4.5.0 after this is merged, and then we can also declare support for the various Ruby versions.

jrafanie
jrafanie approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jrafanie jrafanie merged commit 6fe6f66 into ManageIQ:master Sep 3, 2024
8 checks passed
@jrafanie
Copy link
Member

jrafanie commented Sep 3, 2024

@jrafanie Separately I noticed we haven't had a release in a long time, and one of my PRs I needed recently. I'm going to release a 4.5.0 after this is merged, and then we can also declare support for the various Ruby versions.

sure, the diff doesn't look so bad... just the hierarchy change plus this one...some test changes.

v4.4.0...master

@Fryguy Fryguy deleted the add_ruby_32_33 branch September 3, 2024 19:03
Fryguy added a commit that referenced this pull request Sep 3, 2024
@Fryguy
Release v4.5.0
9a91e7f 
Added:
- Added Ruby 3.0 and 3.1 support [#114]
- Added Ruby 3.2 and 3.3 support [#123]
- Add Class#hierarchy block support to allow formatting of classes [#113]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

Assignees

@jrafanie jrafanie

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fryguy @jrafanie