Skip to content

Commit

Permalink
[bugfix] added missing timeout config for doRequestList() (#356)
Browse files Browse the repository at this point in the history
* added missing timeout config for doRequestList()

* re-enabled test

---------

Co-authored-by: Iulian Masar <[email protected]>
  • Loading branch information
iulian03 and Iulian Masar authored Feb 28, 2025
1 parent 744202e commit 7a70e80
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
4 changes: 4 additions & 0 deletions src/main/java/com/mangopay/core/RestTool.java
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,10 @@ private <T extends Dto> List<T> doRequestList(Class<T[]> classOfT, Class<T> clas
if (connection instanceof HttpsURLConnection) {
configureSslContext((HttpsURLConnection) connection);
}
// Get connection timeout from config
connection.setConnectTimeout(this.root.getConfig().getConnectTimeout());
// Get read timeout from config
connection.setReadTimeout(this.root.getConfig().getReadTimeout());

// set request method
connection.setRequestMethod(this.requestType);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import com.mangopay.entities.VirtualAccount;
import com.mangopay.entities.Wallet;
import com.mangopay.entities.subentities.VirtualAccountAvailabilities;
import org.junit.Ignore;
import org.junit.Test;

import java.util.List;
Expand Down Expand Up @@ -46,15 +45,13 @@ public void getAllVirtualAccounts() throws Exception {
assertEquals(1, virtualAccounts.size());
}

// TODO
@Ignore("API issue. Re-enable after fix.")
@Test
public void getAvailabilities() throws Exception {
VirtualAccountAvailabilities availabilities = this.api.getVirtualAccountApi().getAvailabilities();

assertNotNull(availabilities);
assertTrue(availabilities.getCollection().getClass().isArray());
assertTrue(availabilities.getUserOwned().getClass().isArray());
assertFalse(availabilities.getCollection().isEmpty());
assertFalse(availabilities.getUserOwned().isEmpty());
}

@Test
Expand Down

0 comments on commit 7a70e80

Please sign in to comment.