Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address feedback #21

Merged
merged 10 commits into from
Aug 27, 2020
Merged

Address feedback #21

merged 10 commits into from
Aug 27, 2020

Conversation

Malvoz
Copy link
Member

@Malvoz Malvoz commented Aug 27, 2020

Addresses some of @zcorpan's feedback in #17.

Also adds a TOC after the Introduction.

@prushforth please see the individual commit messages for details.

Address the following feedback from Maps4HTML#17:

> > So, What Is The Problem to Solve?
>
> How is this section different from the previous one? (Should this be "The Proposal"?)
Address the following feedback from Maps4HTML#17:

> > - Follow the HTML Design Principles to create HTML elements and attributes that
>
> This is part of the proposal and doesn't belong in the goals.
Address the following feedback from Maps4HTML#17:

> > - Changing the operating model or availability of existing spatial (map) content management systems, APIs and Web Services.
> > - Backwards-incompatible changes to HTML / breaking the Web
>
> Breaking the web is not a non-goal, it's an anti-goal (or requirement to not do).
Address the following feedback in Maps4HTML#17:

> > The complexity of choices and the wide variety of technologies required to create Web maps results in maps of highly variable usability and accessibility.
>
> I don't really follow this. Usability and accessibility are used but without substance.
Address the following feedback from Maps4HTML#17:

> > A working example custom element prototype is available (although it’s not yet a fully compliant ‘polyfill’. For one thing, it doesn’t work on Webkit due to the use of custom built-in elements. A parallel <geo-map> autonomous custom element suite is available for Webkit. For another, the light DOM content of <layer> is not currently active or available as an API).
>
> Move the polyfill reference to an appendix or separate section.

Also change mention of `<geo-map>` to `<mapml-viewer>`.
@prushforth
Copy link
Member

I need to go through Simon's comments and address feedback, too, but I will layer that work on top of this work. Many thanks to you for starting things off.

@prushforth prushforth merged commit 56cf3b2 into Maps4HTML:master Aug 27, 2020
@Malvoz Malvoz deleted the address-feedback branch May 4, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants