-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address feedback #21
Merged
Merged
Address feedback #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address the following feedback from Maps4HTML#17: > > So, What Is The Problem to Solve? > > How is this section different from the previous one? (Should this be "The Proposal"?)
Address the following feedback from Maps4HTML#17: > > - Follow the HTML Design Principles to create HTML elements and attributes that > > This is part of the proposal and doesn't belong in the goals.
Address the following feedback from Maps4HTML#17: > > - Changing the operating model or availability of existing spatial (map) content management systems, APIs and Web Services. > > - Backwards-incompatible changes to HTML / breaking the Web > > Breaking the web is not a non-goal, it's an anti-goal (or requirement to not do).
Address the following feedback in Maps4HTML#17: > > The complexity of choices and the wide variety of technologies required to create Web maps results in maps of highly variable usability and accessibility. > > I don't really follow this. Usability and accessibility are used but without substance.
Address the following feedback from Maps4HTML#17: > > A working example custom element prototype is available (although it’s not yet a fully compliant ‘polyfill’. For one thing, it doesn’t work on Webkit due to the use of custom built-in elements. A parallel <geo-map> autonomous custom element suite is available for Webkit. For another, the light DOM content of <layer> is not currently active or available as an API). > > Move the polyfill reference to an appendix or separate section. Also change mention of `<geo-map>` to `<mapml-viewer>`.
I need to go through Simon's comments and address feedback, too, but I will layer that work on top of this work. Many thanks to you for starting things off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some of @zcorpan's feedback in #17.
Also adds a TOC after the Introduction.
@prushforth please see the individual commit messages for details.