Add contextmenu for map-extent layercontrol #930
Conversation
popupTabNavigation.test.js. Playwright docs say page.click('body') is
discouraged...
layerContextMenuKeyboard and popupTabNavigation, hopefully
| @@ -71,6 +71,45 @@ export class MapExtent extends HTMLElement { | |||
| ? getExtent(this) | |||
| : getCalculatedExtent(this); | |||
| } | |||
|
|
|||
| getOuterHTML() { | |||
| let tempElement = this.cloneNode(true); | |||
There was a problem hiding this comment.
I attempted, but failed to re-write this without cloning the live element. It's that cloning that yields the console logging due to disconnected map-input and so on (I believe). That logging seems to interfere with the tests, and what's concerning is that it doesn't appear to happen consistently.
| @@ -107,7 +146,7 @@ export class MapExtent extends HTMLElement { | |||
| case 'label': | |||
| if (oldValue !== newValue) { | |||
| this._layerControlHTML.querySelector( | |||
| '.mapml-layer-item-name' | |||
| '.mapml-extent-item-name' | |||
| @@ -16,8 +16,8 @@ test.describe('Using arrow keys to navigate context menu', () => { | |||
|
|
|||
| test('Testing layer contextmenu', async () => { | |||
| await page.waitForTimeout(500); | |||
| await page.click('body > mapml-viewer'); | |||
There was a problem hiding this comment.
this is not recommended by playwright, so I changed a few of them where they seemed to cause some flakiness
|
Thanks @prushforth! Will merge after finalizing Maps4HTML/mapml-extension#69 |
We should merge this when it's ready so that we can release it as 0.13.1 (with a small other GeoServer-related change that wouldn't pass CI reliably without these commits) with GeoServer 2.25.0, which will happen March 18th. I could merge that change without this, of course, but it was easier to rebase it on the work done in this branch which eliminates some test flakiness (there's always a new source of flakiness, for some reason). The GeoServer viewer should not depend on the extension, but I agree the extension needs this update. I will open a GeoServer PR this week to include the new viewer, which we can update until Friday. |
|
I'll cut a 0.13.1 release later today, hopefully in time to make the GeoServer 2.25.0 release cut-off, tbd. |
Closes #926
Re-key copy layer/extent shortcut from 'L' to 'C'?Future work