fix(core): warn about missing metrics only once

MarathonLabs · Aug 13, 2023 · 9c797fe · 9c797fe
1 parent b622e54
commit 9c797fe
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/core/src/main/kotlin/com/malinskiy/marathon/analytics/external/MetricsProviderImpl.kt b/core/src/main/kotlin/com/malinskiy/marathon/analytics/external/MetricsProviderImpl.kt
@@ -45,7 +45,10 @@ class MetricsProviderImpl(private val remoteDataStore: RemoteDataSource) : Metri
 
         val testName = test.toSafeTestName()
         return successRateMeasurements[key]?.get(testName) ?: {
-            logger.warn { "No success rate found for $testName. Using 0 i.e. fails all the time" }
+            if (!warningSuccessRateTimeReported.contains(testName)) {
+                logger.warn { "No success rate found for $testName. Using 0 i.e. fails all the time" }
+                warningSuccessRateTimeReported.add(testName)
+            }
             0.0
         }()
     }
@@ -77,11 +80,17 @@ class MetricsProviderImpl(private val remoteDataStore: RemoteDataSource) : Metri
         }
         val testName = test.toSafeTestName()
         return executionTimeMeasurements[key]?.get(testName) ?: {
-            logger.warn { "No execution time found for $testName. Using 300_000 seconds i.e. long test" }
+            if (!warningExecutionTimeReported.contains(testName)) {
+                logger.warn { "No execution time found for $testName. Using 300_000 seconds i.e. long test" }
+                warningExecutionTimeReported.add(testName)
+            }
             300_000.0
         }()
     }
 
+    private val warningExecutionTimeReported = hashSetOf<String>()
+    private val warningSuccessRateTimeReported = hashSetOf<String>()
+
     private fun fetchExecutionTime(percentile: Double, limit: Instant) = runBlocking {
         withRetry(3, RETRY_DELAY) {
             remoteDataStore.requestAllExecutionTimes(percentile, limit)