[ci] fixed vtest compare exit code on CI

MarcSabatella · Jul 17, 2023 · d4406fb · d4406fb
1 parent 6d215f2
commit d4406fb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/ci_vtests.yml b/.github/workflows/ci_vtests.yml
@@ -145,7 +145,7 @@ jobs:
     - name: Compare PNGs
       run: |
         echo "VTEST_DIFF_FOUND=false" >> $GITHUB_ENV
-        ./vtest/vtest-compare-pngs.sh
+        ./vtest/vtest-compare-pngs.sh --ci 1
     - name: Upload comparison
       if: env.VTEST_DIFF_FOUND == 'true'
       uses: actions/upload-artifact@v3

diff --git a/vtest/vtest-compare-pngs.sh b/vtest/vtest-compare-pngs.sh
@@ -25,13 +25,15 @@ CURRENT_DIR="./current_pngs"
 REFERENCE_DIR="./reference_pngs"
 OUTPUT_DIR="./comparison"
 GEN_GIF=1
+CI_MODE=0
 
 while [[ "$#" -gt 0 ]]; do
     case $1 in
         -c|--current-dir) CURRENT_DIR="$2"; shift ;;
         -r|--reference-dir) REFERENCE_DIR="$2"; shift ;;
         -o|--output-dir) OUTPUT_DIR="$2"; shift ;;
         -g|--gen-gif) GEN_GIF=$2; shift ;;
+        --ci) CI_MODE=$2; shift ;;
         *) echo "Unknown parameter passed: $1"; exit 1 ;;
     esac
     shift
@@ -117,5 +119,9 @@ if [ "$VTEST_DIFF_FOUND" == "true" ]; then
     echo "  </body>" >> $HTML
     echo "</html>" >> $HTML
 
-    exit 1
+    if [ $CI_MODE -eq 1 ]; then
+        exit 0
+    else
+        exit 1
+    fi
 fi