-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable resetting application context user to null #4415
Enable resetting application context user to null #4415
Conversation
…hen FlowSecurityPrincipalFromClient is enabled. Fixes #4410
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in the clear context method - which is there to ensure nothing is left on the server once the data portal operation is complete.
I'm wondering why it matters if the value is left as a null, because nobody should be using it anyway - we're just cleaning up at this point, immediately before leaving the server to return to the client.
It matters because we have implementations which don't accept null as a new principal on the application context. Edit: I'll make it |
Revert change in DataPortal Fixes #4410
Converted the PR to draft. |
So. I kept the |
Set application context user to an unauthenticated claims principal when
FlowSecurityPrincipalFromClient
is enabled.Fixes #4410