Updating for importing into external projects #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated README.md with properties changes. Removed access_token.yaml since it's replaced by properties.yml. Added TODOs for test assertions
General code cleanup (String interpolation, removing spaces around method calls, replacing if-else-if with when). Updated README.md to include environment variable instructions.
arocnies
changed the title
arocnies
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to import this into another project but I couldn't find it on Maven Central, JCenter, etc.
I've converted it to a Gradle project so it can be used as a source dependency.
I've also reformated the code to be closer to the official style and some minor code cleanup.
I added a properties override so I don't have to worry about committing my YNAB access token or other test IDs.
I think there may be some issues. I'm not able to get all of the tests to run against my budget yet--maybe you can test it out?
Thanks for publishing the project!