Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding guild channels to the simple-demo. #23

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Lil-Pandaa
Copy link
Contributor

@Lil-Pandaa Lil-Pandaa commented Dec 30, 2022

I've fixed the majority of issues that were located in my last PR ( #22 ).

Can be merged if you:

  • Fix broken path for includes directory in index.php. ☑️

  • Add the new function to the root discord.php, as per contributing guidelines.☑️

  • Use the variable defined in the config.php for bot token, like in the other example functions.☑️

  • Comment out the feature in login.php, and skip the manual check in the file completely. You can do a check to see if the session variable is populated on the index page, and only display the table if it is set instead. ⬛
    I think I have done what you're asking however I'm not entirely sure.

  • Remove duplicate channels in the table. The example of checking the type should suffice. ☑️

In the future, please be wary of committing sensitive data to your repo, and especially trying to push these upstream.
While I'm able to squash the commits, to leave out the information, it will still show up in your own repo.

Thank you for pointing this out to me. I have deleted the old repo and re-forked it so that the old leaked token, although it has been regenerated, is now not viewable by the public eye.

Any questions please @ me or ping me inside discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant