Skip to content
This repository has been archived by the owner on Jan 3, 2025. It is now read-only.

Implement top level "invoking" function to chain throwable assertions #132

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

rubengees
Copy link
Contributor

This implements the second proposal in #111. The tests have been adjusted to showcase the new syntax. This is basically what @aerb suggested.

  • I've added my name to the AUTHORS file, if it wasn't already present.

This implements the second proposal in MarkusAmshove#111. The tests have been
adjusted to showcase the new syntax.
@MarkusAmshove
Copy link
Owner

Thanks for the contribution, this looks good!

I'm currently on mobile so I can't test it out, but does this change break existing code?
From the diff it doesn't look like the invoking is needed, which is good for existing code :-)

@rubengees
Copy link
Contributor Author

No, it's completely optional 🙂

@MarkusAmshove MarkusAmshove merged commit 646035b into MarkusAmshove:master Jan 26, 2019
@MarkusAmshove
Copy link
Owner

Thank you, I've reviewed it and it works fine :-)

I'll release it this weekend, as I want to see if I can update the Gradle build with some of the new kotlin stuff they released

@rubengees
Copy link
Contributor Author

Cool, thanks!

@rubengees rubengees deleted the 111-invoking branch January 26, 2019 18:46
@MarkusAmshove
Copy link
Owner

It is now part of 1.47 🚢

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants