Feat: Adjust find_rej_files() with argument for finding hidden .rej files
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanLoor
changed the title
find_rej_files to also return hidden .rej files.find_rej_files() to also return hidden .rej files.
MarkusSagen
reviewed
Jul 18, 2024
MarkusSagen
changed the title
find_rej_files() to also return hidden .rej files.find_rej_files() with argument for finding hidden .rej files
|
@MarkusSagen good idea - done! |
…w no-hidden flag without defaults
|
Great change! Merging |
|
@MarkusSagen Would you mind making a new release to pypi with these changes also? Latest version on pypi is 0.0.3 (https://pypi.org/project/rejx/#history) |
|
@MarkusSagen sorry to ping you again.. would be great if you can make a pypi release |
|
Sorry! Been a bit busy and had vacation |
|
@timvink @StephanLoor Included now in the |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently aren't checking for hidden .rej files (i.e. filenames starting with
.). This functionality is desirable, as the config of e.g. pre-commit hooks and cruft are maintained in hidden files by default. This PR adds this functionality.