Bug fixes and new features #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to try and make free space...
…od of it picking up the items
…sabled and also fixed an issue with aiming at entity incorrectly on servers specifically chikens cant be killed
…esource tasks are running for a long time
…mes becomes null causing a crash
…clef into LegitMineFeature
…ade bot get a stone sword if no other swords are available
…s system gets stuck
… block as if it stops early it can get stuck
…and place penalty as well as cost heuristics
…is dangerous check to drop and block searches
…cursive command execution.
|
The FPS drops you are talking about is likely a memory leak in the mod. Fixed it on my fork in this commit: MiranCZ/altoclef@2c1863b |
JustaSqu1d
suggested changes
Aug 13, 2024
Comment on lines
138
to
184
| if(block == Blocks.COAL_ORE || block == Blocks.DEEPSLATE_COAL_ORE) | ||
| { | ||
| maxHeight = 192; | ||
| optimalHeight = 96; | ||
| minHeight = 0; | ||
| }else | ||
| if(block == Blocks.COPPER_ORE || block == Blocks.DEEPSLATE_COPPER_ORE) | ||
| { | ||
| maxHeight = 112; | ||
| optimalHeight = 48; | ||
| minHeight = -16; | ||
| }else | ||
| if(block == Blocks.IRON_ORE || block == Blocks.DEEPSLATE_IRON_ORE) | ||
| { | ||
| maxHeight = 72; | ||
| optimalHeight = 16; | ||
| minHeight = -32; | ||
| }else | ||
| if(block == Blocks.LAPIS_ORE || block == Blocks.DEEPSLATE_LAPIS_ORE) | ||
| { | ||
| maxHeight = 64; | ||
| optimalHeight = 0; | ||
| minHeight = -59; | ||
| }else | ||
| if(block == Blocks.GOLD_ORE || block == Blocks.DEEPSLATE_GOLD_ORE) | ||
| { | ||
| maxHeight = 32; | ||
| optimalHeight = -16; | ||
| minHeight = -59; | ||
| }else | ||
| if(block == Blocks.DIAMOND_ORE || block == Blocks.DEEPSLATE_DIAMOND_ORE) | ||
| { | ||
| maxHeight = 15; | ||
| optimalHeight = -59; | ||
| minHeight = -59; | ||
| }else | ||
| if(block == Blocks.REDSTONE_ORE || block == Blocks.DEEPSLATE_REDSTONE_ORE) | ||
| { | ||
| maxHeight = 15; | ||
| optimalHeight = -59; | ||
| minHeight = -59; | ||
| }else | ||
| { | ||
| maxHeight = 8; | ||
| optimalHeight = 8; | ||
| minHeight = 8; | ||
| } |
Comment on lines
57
to
69
| try { | ||
| int num = Integer.parseInt(part); | ||
| numbers.add(num); | ||
| } catch (NumberFormatException e) { | ||
| try { | ||
| dimension = (Dimension) Arg.parseEnum(part, Dimension.class); | ||
| } catch (CommandException e1) { | ||
| // TODO Auto-generated catch block | ||
| e1.printStackTrace(); | ||
| Debug.logWarning(e1.getMessage()); | ||
| return null; | ||
| } | ||
| break; |
There was a problem hiding this comment.
Use a "look before you leap" approach instead of "ask for forgiveness than permission"
Comment on lines
116
to
126
| try { | ||
| int num = Integer.parseInt(part); | ||
| numbers.add(num); | ||
| } catch (NumberFormatException e) { | ||
| try { | ||
| dimension = (Dimension) Arg.parseEnum(part, Dimension.class); | ||
| } catch (CommandException e1) { | ||
| // TODO Auto-generated catch block | ||
| e1.printStackTrace(); | ||
| } | ||
| break; |
src/main/java/adris/altoclef/tasks/resources/MineAndCollectTask.java
Outdated
Show resolved
Hide resolved
src/main/java/adris/altoclef/tasks/resources/MineAndCollectTask.java
Outdated
Show resolved
Hide resolved
…r formal and Added raw blocks to list
JustaSqu1d
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
************* Fixes *************
************* Additions *************
************* Bugs *************
No currently known bugs
Information
Checklist