OB reference app phase 2 completed

.github/workflows/build.yml

@@ -1,8 +1,7 @@
 name: Build
 on:
     push:
-        branches:
-            - develop
+        branches: ['main', 'develop']
     pull_request:
         types: [opened, synchronize, reopened]
 jobs:
@@ -13,6 +12,10 @@ jobs:
             - uses: actions/checkout@v3
               with:
                   fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
+            - name: Install dependencies
+              run: npm install
+            - name: Test and coverage
+              run: npm run test:coverage
             - name: SonarCloud Scan
               uses: SonarSource/sonarcloud-github-action@master
               env:

Dockerfile

@@ -1,5 +1,5 @@
 FROM node:18-alpine
 WORKDIR /app
 COPY . .
-RUN npm i
+RUN npm i --ignore-scripts
 CMD ["npm", "start"]

README.md

@@ -5,6 +5,7 @@
 [![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=Mastercard_open-banking-reference-application-australia&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=Mastercard_open-banking-reference-application-australia)
 [![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=Mastercard_open-banking-reference-application-australia&metric=reliability_rating)](https://sonarcloud.io/summary/new_code?id=Mastercard_open-banking-reference-application-australia)
 [![Duplicated Lines (%)](https://sonarcloud.io/api/project_badges/measure?project=Mastercard_open-banking-reference-application-australia&metric=duplicated_lines_density)](https://sonarcloud.io/summary/new_code?id=Mastercard_open-banking-reference-application-australia)
+[![Coverage](https://sonarcloud.io/api/project_badges/measure?project=Mastercard_open-banking-reference-application-australia&metric=coverage)](https://sonarcloud.io/summary/new_code?id=Mastercard_open-banking-reference-application-australia)
 
 ## Table of Contents
 

sonar-project.properties

@@ -1,14 +1,15 @@
+# Root project information
 sonar.projectKey=Mastercard_open-banking-reference-application-australia
+sonar.projectName=open-banking-reference-application-australia
+sonar.projectVersion=1.0
 sonar.organization=mastercard
 
+# Exclusions parameters
+sonar.exclusions=Dockerfile,src/tests/**,public/**
 
-# This is the name and version displayed in the SonarCloud UI.
-#sonar.projectName=open-banking-reference-application-australia
-#sonar.projectVersion=1.0
+# Test coverage parameters
+sonar.javascript.lcov.reportPaths=./coverage/lcov.info
+sonar.coverage.exclusions=src/**/*.ts,src/*.js,src/App.tsx,src/index.tsx,/*.js
 
-
-# Path is relative to the sonar-project.properties file. Replace "\" by "/" on Windows.
-#sonar.sources=.
-
-# Encoding of the source code. Default is default system encoding
-#sonar.sourceEncoding=UTF-8
+# Duplication exclusion parameters
+sonar.cpd.exclusions=src/components/Product/data/index.ts

src/components/ConnectForm/ConnectForm.tsx

@@ -296,7 +296,7 @@ export default function ConnectForm() {
                 }
             }
         } catch (error: any) {
-            console.error(error?.message);
+            console.log(error?.message);
             throw error;
         }
     };
@@ -645,7 +645,7 @@ export default function ConnectForm() {
                                                                 {accord.id ===
                                                                     'panel0' &&
                                                                 AUTO_CREATE_CUSTOMER
-                                                                    ? 'AUTO COMPLETE'
+                                                                    ? 'AUTO CREATION COMPLETE'
                                                                     : 'COMPLETE'}
                                                             </Typography>
                                                         )

src/components/SandBoxTip/SandBoxTip.tsx

@@ -36,10 +36,10 @@ export default function SandBoxTip() {
 
                     <div className='flex flex-col items-start gap-4 w-1/3'>
                         <Typography className='mb-2 text-base !font-[700]'>
-                            {data.text.passwordField}
+                            Banking Password
                         </Typography>
                         <Typography className='text-base'>
-                            {data.text.passwordValue}
+                            profile_4100
                         </Typography>
                     </div>
                 </div>

src/components/SandBoxTip/data/index.ts

@@ -3,8 +3,6 @@ const data = {
         tip: ' Please select Finbank Aus OAuth and use the following username and password.',
         usernameField: 'User ID',
         usernameValue: 'profile_4100',
-        passwordField: 'Banking Password',
-        passwordValue: 'profile_4100',
     },
 };
 

src/tests/ConnectForm.test.tsx

@@ -84,7 +84,7 @@ describe('Testing ConnectForm Component', () => {
         );
 
         await user.click(screen.getByRole('button', { name: /View demo/i }));
-        const element = await screen.findByText(/AUTO COMPLETE/i);
+        const element = await screen.findByText(/AUTO CREATION COMPLETE/i);
         expect(element).toBeInTheDocument();
         const connectElement = await screen.findByText('Connect Bank Account');
         expect(connectElement).toBeInTheDocument();

src/tests/ExternalIcon.test.tsx

@@ -0,0 +1,16 @@
+import { render } from '@testing-library/react';
+import { ExternalIcon } from '../components';
+
+describe('Testing ExternalIcon component', () => {
+    test('Should render ExternalIcon', () => {
+        render(
+            (
+                <ExternalIcon data={'#FFFFFF'} background={'#FFF'} />
+            ) as React.ReactElement
+        );
+    });
+
+    test('Should render ExternalIcon - 2', () => {
+        render((<ExternalIcon background={'#FFF'} />) as React.ReactElement);
+    });
+});